Skip to content

Use existing fast path for reading utf8 strings from IL #9974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 20, 2020
Merged

Use existing fast path for reading utf8 strings from IL #9974

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/absil/ilread.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,10 +218,9 @@ let rec seekCountUtf8String mdv addr n =
if c = 0 then n
else seekCountUtf8String mdv (addr+1) (n+1)

let seekReadUTF8String mdv addr =
let seekReadUTF8String (mdv: BinaryView) addr =
let n = seekCountUtf8String mdv addr 0
let bytes = seekReadBytes mdv addr n
System.Text.Encoding.UTF8.GetString (bytes, 0, bytes.Length)
mdv.ReadUtf8String (addr, n)

let seekReadBlob mdv addr =
let struct (len, addr) = seekReadCompressedUInt32 mdv addr
Expand Down