fix VS insertion step #9693
Merged
fix VS insertion step #9693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinRansom
approved these changes
Jul 14, 2020
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Feb 23, 2021
* add retry logic to log downloader * download logs as zip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To find values needed to perform a VS insertion, we have to download around 500 individual log files and parse them all with a regex. This is slow and error-prone, and recently has been timing out. The first part of this PR would retry each log up to 5 times. That's slightly more stable, but not necessarily. The second part of this PR abuses an undocumented API shape to download all logs as a single zip file and then only the interesting ones (e.g., one of them) is checked with the regex. This should be much faster and more stable, assuming the undocumented API doesn't disappear. If it does disappear, there's a one-line change that will switch back to the 500 item download.
Tested via internal build.