Moved fsharpqa/Conformance/BasicGrammarElements/Constants test cases to NUnit #9626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinRansom
suggested changes
Jul 5, 2020
| """ | ||
| let foo = 1up // int | ||
| let x = _52 | ||
| """ |
Contributor
There was a problem hiding this comment.
The test is checking that an identifier that a literal that starts with a numeric is detected as invalid, and is a valid test case, why the change?
Thanks
Kevin
Contributor
Author
There was a problem hiding this comment.
The original test case for 1up got merged as a InlineData into the Theory above, with other similar test cases from this migration.
The _52 test case is from this migration (put it as separate, because it has a different behaviour, i.e. two error messages).
Contributor
There was a problem hiding this comment.
sweet, thanks.
KevinRansom
approved these changes
Jul 6, 2020
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Feb 23, 2021
…to NUnit (dotnet#9626) * Migrated DecimalLiterals01.fs test case * Migrated DecimalConstants02.fs test case * Migrated E_BasicConstantsBigNum01.fs test case * Migrated E_BasicConstantsBigNum40.fs test case * Removed unlisted test case * Migrated E_UnderscoreLiterals.fs test case * Migrated FullSetOfEscapeCharacters.fs test case * Migrated NegativeNumbers01.fs, NegativeNumbers02.fs, NegativeNumbers03.fs test cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #7075.