Skip to content

Fix issue with tests, see #9617 #9622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jul 21, 2020
Merged

Fix issue with tests, see #9617 #9622

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
9fdbb91
Ignore NCrunch temp files and local user files
abelbraaksma Jul 3, 2020
f6256e3
Showing only failing line in ExprTests, cleanup temp files
abelbraaksma Jul 4, 2020
3eb988d
Show sensible message when UnresolvedPathReferenceNoRange is raised b…
abelbraaksma Jul 4, 2020
07822df
Attempt to re-enable two base tests, may need to be re-disabled for Mono
abelbraaksma Jul 4, 2020
3f0d533
Cleanup tests that use global state, ensure deletion of temp files
abelbraaksma Jul 4, 2020
f1c0904
Fix difference Mono, fix spacing difference CI vs VS IDE
abelbraaksma Jul 4, 2020
513345e
Normalize null vs None
abelbraaksma Jul 4, 2020
bc2c707
Fix next issue difference between CI and local
abelbraaksma Jul 4, 2020
8caa000
Make sure both smoke tests use the same filterhack function
abelbraaksma Jul 4, 2020
6684c2b
Next fix, overlooked
abelbraaksma Jul 4, 2020
60fa6b1
Add procid and threadid to temp file
abelbraaksma Jul 11, 2020
2a64fa8
Move #r System.Numerics to mkStandardProjectReferences
abelbraaksma Jul 11, 2020
04b8032
Cleanup
abelbraaksma Jul 11, 2020
70b58eb
Fix tests that actually count references and are dependent on Common.fs
abelbraaksma Jul 11, 2020
8fb768f
Merge branch 'master' into Fix-issue-with-tests-9617
abelbraaksma Jul 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,3 +134,7 @@ msbuild.binlog
/tests/fsharp/regression/5531/compilation.output.test.txt
/tests/fsharp/core/fsfromfsviacs/compilation.langversion.old.output.txt
/tests/fsharp/core/fsfromfsviacs/compilation.errors.output.txt
*ncrunch*.user
_NCrunch_*
.*crunch*.local.xml
nCrunchTemp_*
7 changes: 6 additions & 1 deletion src/fsharp/ErrorLogger.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,12 @@ exception PossibleUnverifiableCode of range

exception UnresolvedReferenceNoRange of (*assemblyName*) string
exception UnresolvedReferenceError of (*assemblyName*) string * range
exception UnresolvedPathReferenceNoRange of (*assemblyName*) string * (*path*) string
exception UnresolvedPathReferenceNoRange of (*assemblyName*) string * (*path*) string with
override this.Message =
match this :> exn with
| UnresolvedPathReferenceNoRange(assemblyName, path) -> sprintf "Assembly: %s, full path: %s" assemblyName path
| _ -> "impossible"

exception UnresolvedPathReference of (*assemblyName*) string * (*path*) string * range


Expand Down
1 change: 1 addition & 0 deletions tests/service/Common.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@ let mkStandardProjectReferences () =
[ yield sysLib "mscorlib"
yield sysLib "System"
yield sysLib "System.Core"
yield sysLib "System.Numerics"
yield fsCoreDefaultReference() ]
#endif

Expand Down
Loading