Moved fsharpqa/Libraries/Core/LanguagePrimitives FSI test cases to NUnit #9435
Conversation
|
|
||
| CompilerAssert.RunScriptWithOptions [| "--langversion:preview" |] | ||
| """ | ||
| let assertEqual a b = |
There was a problem hiding this comment.
Is there some reason you didn't use Assert.areEqual?
There was a problem hiding this comment.
Partly following the example in #9396 (comment), partly because it seemed easier than importing NUnit into FSI (might well be, that I'm just not aware of an easy way)).
There was a problem hiding this comment.
Oh of course, the assertion is happening within the executing code, it is not verifying the results. That makes perfect sense. Indeed I just did exactly the same thing in a test I added last night.
@vzarytovskii , we should consider having some form of Assertions framework used from within the compiled sources. That would probably stop us from adding our own unique assertions every time we check-in new tests.
There was a problem hiding this comment.
@vzarytovskii , we should consider having some form of Assertions framework used from within the compiled sources. That would probably stop us from adding our own unique assertions every time we check-in new tests.
@KevinRansom, I was pondering the same for a little while. Is there any method to make functions available within such code snippets? Preferably a better one than string manipulation?
There was a problem hiding this comment.
@ThorstenReichert
We are running a compiler within the test, so we can simply have a library and ensure the test references it. That works for the compiler and for FSI.
/cc @vzarytovskii
KevinRansom
left a comment
KevinRansom
left a comment
There was a problem hiding this comment.
Thanks for taking care of this, it is super helpful.
Kevin
…nit (dotnet#9435) * Migrated comparison FSI test case * Migrated string format FSI test case
3 participants
Contributes to #7075.