Skip to content

Conversation

@KevinRansom
Copy link
Contributor

Fixes: #9420

Regression: DU case at pattern match site no longer requires parameter #9420

A recent PR here caused a regression in Pattern matching validation. This PR is intended to fix it.

  • Adds a regression test case.
  • Also fixes the case that DUs with tuple args produced one error message if only a single arg was provided, but another if multiple args were provided.

//cc @auduchinok , @dsyme

@KevinRansom KevinRansom changed the title Fix recovery Fix recovery #9420 Jun 11, 2020
@auduchinok
Copy link
Member

@KevinRansom Thank you for this.

@KevinRansom
Copy link
Contributor Author

@auduchinok , thank you for the original work, basically I just fixed a typo :-)

Copy link
Contributor

@TIHan TIHan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@TIHan TIHan merged commit 6304b2e into dotnet:master Jun 11, 2020
@KevinRansom KevinRansom deleted the fixtcpmrecovery branch August 19, 2020 20:22
nosami pushed a commit to xamarin/visualfsharp that referenced this pull request Feb 23, 2021
* fix pattern match recovery

* add testcase and fixup

* Update TypeChecker.fs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Regression: DU case at pattern match site no longer requires parameter

4 participants