Remove List.headAndTail and some tuples #9336
Conversation
| let wrap, h', _readonly, _writeonly = mkExprAddrOfExpr g true false PossiblyMutates h None m | ||
| Some (wrap (Expr.Op (TOp.TraitCall traitInfo, [], (h' :: t), m))) | ||
| if minfo.IsStruct && minfo.IsInstance then | ||
| match argExprs with |
There was a problem hiding this comment.
This isn't quite the same, it's missing the [] -> false case.
There was a problem hiding this comment.
@cartermp , I believe that case is taken care of in isByRefTy but boolean logic has always been my downfall.
let isByrefTy g ty =
ty |> stripTyEqns g |> (function
| TType_app(tcref, _) when g.byref2_tcr.CanDeref -> tyconRefEq g g.byref2_tcr tcref
| TType_app(tcref, _) -> tyconRefEq g g.byref_tcr tcref
| _ -> false)
There was a problem hiding this comment.
I also suffer from boolean logic, which is also why I think it'd be better if the original [] -> false case was restored
There was a problem hiding this comment.
@cartermp no the [] case is still there. It's just rearranged
There was a problem hiding this comment.
Or maybe more correct: one of the two tests for [] is still in place
There was a problem hiding this comment.
It is, I see it now, I was always hopeless at where's waldo.
There was a problem hiding this comment.
aha, I think I see it now too. The original code was so hard to read
| let wrap, h', _readonly, _writeonly = mkExprAddrOfExpr g true false PossiblyMutates h None m | ||
| Some (wrap (Expr.Op (TOp.TraitCall traitInfo, [], (h' :: t), m))) | ||
| if minfo.IsStruct && minfo.IsInstance then | ||
| match argExprs with |
There was a problem hiding this comment.
@cartermp , I believe that case is taken care of in isByRefTy but boolean logic has always been my downfall.
let isByrefTy g ty =
ty |> stripTyEqns g |> (function
| TType_app(tcref, _) when g.byref2_tcr.CanDeref -> tyconRefEq g g.byref2_tcr tcref
| TType_app(tcref, _) -> tyconRefEq g g.byref_tcr tcref
| _ -> false)
3 participants
No description provided.