Show keyword descriptions in completion + refactor #9164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
KevinRansom
approved these changes
May 11, 2020
Contributor
KevinRansom
left a comment
KevinRansom
left a comment
There was a problem hiding this comment.
It looks great, consider whether you want to update to include a couple of extra fsi directives?
| HashCompletion.Create("""\s*#load\s+(@?"*(?<literal>"[^"]*"?))""", [ ".fs"; ".fsx" ], useIncludeDirectives = true) | ||
| HashCompletion.Create("""\s*#r\s+(@?"*(?<literal>"[^"]*"?))""", [ ".dll"; ".exe" ], useIncludeDirectives = true) | ||
| HashCompletion.Create("""\s*#I\s+(@?"*(?<literal>"[^"]*"?))""", [ "\x00" ], useIncludeDirectives = false) | ||
| ] |
Contributor
There was a problem hiding this comment.
have you considered:
#if, #else, #endif, and #time.
Contributor
Author
There was a problem hiding this comment.
All four could be interesting. Since this mainly just calls into Roslyn's file system completion it'd have to be handled a little differently though.
Contributor
Author
There was a problem hiding this comment.
For the first three, we'd need to look at the environment and grab MSBuild defines. #time would be just a static "on"/"off".
TIHan
approved these changes
May 12, 2020
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Feb 23, 2021
* Completion provider refactor * Actually show keyword descriptions in tooltips for completion * Get rid of unnecessary property * Make the keyword completion list static again * Just do it in the CompletionProvider
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Jan 26, 2022
* Completion provider refactor * Actually show keyword descriptions in tooltips for completion * Get rid of unnecessary property * Make the keyword completion list static again * Just do it in the CompletionProvider
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Jan 26, 2022
* Completion provider refactor * Actually show keyword descriptions in tooltips for completion * Get rid of unnecessary property * Make the keyword completion list static again * Just do it in the CompletionProvider
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
To my knowledge this hasn't been working in all of VS 2019 and perhaps VS 2017
Also includes some refactoring:
Move keyword completion into a separate provider_since I was in the files