Skip to content

Conversation

@TIHan
Copy link
Contributor

@TIHan TIHan commented May 4, 2020

This will help clear caches from both VS and FCS when a project doesn't exist in the current solution.

Copy link
Contributor

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! If I'm understanding this change correctly, does this prevent the issue where memory stays high when you switch solutions in the same VS session? I believe we referred to that as a memory leak

@TIHan
Copy link
Contributor Author

TIHan commented May 5, 2020

Yes, that is right. :) It wont be perfect I think, but it will certainly help most of the time.

@TIHan TIHan merged commit f5aed4a into dotnet:master May 5, 2020
@cartermp
Copy link
Contributor

cartermp commented May 5, 2020

Love it!

nosami pushed a commit to xamarin/visualfsharp that referenced this pull request Feb 23, 2021
…et#9124)

* Clearing cache of projects that are not in the current solution

* Update LanguageService.fs

* Using seq instead of list

* Fixed build
nosami pushed a commit to xamarin/visualfsharp that referenced this pull request Jan 26, 2022
…et#9124)

* Clearing cache of projects that are not in the current solution

* Update LanguageService.fs

* Using seq instead of list

* Fixed build
nosami pushed a commit to xamarin/visualfsharp that referenced this pull request Jan 26, 2022
…et#9124)

* Clearing cache of projects that are not in the current solution

* Update LanguageService.fs

* Using seq instead of list

* Fixed build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants