Added GetBoundValues and TryFindBoundValue APIs to FsiEvaluationSession #9068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettfo
approved these changes
Apr 29, 2020
| match tryGetGeneratedValue istate cenv v with | ||
| | Some fsiValue -> | ||
| yield FsiBoundValue(nm, fsiValue) | ||
| | _ -> |
Member
There was a problem hiding this comment.
When would istate.boundValues have an item, only to not actually be found by tryGetGeneratedValue?
Contributor
Author
There was a problem hiding this comment.
I think I see what you are saying. Why would there be a try in the first place? If it's there, then we don't need to try. I can always see tryGetGeneratedValue returning something for each item in boundValues. We could throw an error instead of returning nothing, but I was following the existing pattern of handling results when looking up the generated values.
28 tasks
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Feb 23, 2021
…on (dotnet#9068) * Added GetBoundValues/TryFindBoundValue to FsiSession. Added FsiTests. * Added more tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FsiEvaluationSessiondidn't have an easy way to get the state of all values bound to an identifier at the root-level. Before, a user had to rely on listening toValueBoundevents and not able to query for the current state of the value without having to perform anEval.Introducing
GetBoundValuesandTryFindBoundValuetoFsiEvaluationSessionsimplifies this process.