Re-Implemented ILBinaryReader with System.Reflection.Metadata #8081
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Wow, CI passes for the first time. However, there is a perf issue when getting the content of the field using the field's RVA. I think it's reading more than it should. |
Contributor
|
Are there any interesting benchmark results now that it's passing CI? |
TIHan
commented
Nov 10, 2021
| InlineNone(volatileOrUnalignedPrefix (fun (ilAlignment, ilVolatility) -> I_ldind(ilAlignment, ilVolatility, DT_I8)))//byte OperandType.InlineNone // ldind.i8 | ||
| InlineNone(volatileOrUnalignedPrefix (fun (ilAlignment, ilVolatility) -> I_ldind(ilAlignment, ilVolatility, DT_I)))//byte OperandType.InlineNone // ldind.i | ||
| InlineNone(volatileOrUnalignedPrefix (fun (ilAlignment, ilVolatility) -> I_ldind(ilAlignment, ilVolatility, DT_R4)))//byte OperandType.InlineNone // ldind.r4 | ||
|
|
Contributor
Author
There was a problem hiding this comment.
This is incorrect: blobReader.ReadBytes(blobReader.Length)
blobReader.Length will definitely not give back the proper length. We may have to do what the original implementation did.
Member
|
Shelving this for the time being. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work is almost a year old, Jan 4th 2019; I decided to go ahead and try to finish it since I've been doing a lot of work in our IL metadata lately.
It saves about ~1500 lines of code and is a lot more readable.
Acceptance Criteria