Activate suggestions in unit tests and move some tests #7251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@cartermp @KevinRansom somehow CI is not starting |
Contributor
|
Well have to wait until the morning i'm afraid. |
Contributor
|
CI's back up |
# Conflicts: # tests/fsharpqa/Source/Warnings/env.lst
MecuSorin
reviewed
Jul 30, 2019
MecuSorin
reviewed
Jul 30, 2019
| FSharpErrorSeverity.Error | ||
| 39 | ||
| (2, 48, 2, 53) | ||
| "The type 'int11' is not defined. Maybe you want one of the following:\r\n int16\r\n int16`1\r\n int8\r\n uint16\r\n int" |
MecuSorin
reviewed
Jul 30, 2019
MecuSorin
reviewed
Jul 30, 2019
forki
changed the title
Contributor
Author
|
this is ready |
forki
changed the title
cartermp
approved these changes
Jul 30, 2019
KevinRansom
approved these changes
Aug 2, 2019
Contributor
Author
|
all green |
Contributor
|
Thanks for this. |
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Feb 23, 2021
* Moved Suggestion Tests over to NUnit * Try to activate suggestions in unit tests * Fix suggestion tests * Fix suggestion tests * Fix suggestion tests * Fix suggestion tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.