Implement langversion switch for openstaticclasses #7195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
KevinRansom
commented
Jul 11, 2019
KevinRansom
commented
- Add switch support to product
- Plumb tc globals a bit further down
- neg tests for failing to find open static methods
- Enable versioning tests
TIHan
reviewed
Jul 11, 2019
TIHan
reviewed
Jul 11, 2019
TIHan
approved these changes
Jul 11, 2019
Contributor
TIHan
left a comment
TIHan
left a comment
There was a problem hiding this comment.
Looks good, pretty minimal change. Just a quick change requested on the TcGlobals bit which should get rid of some plumbing.
cartermp
approved these changes
Jul 11, 2019
Contributor
cartermp
left a comment
cartermp
left a comment
There was a problem hiding this comment.
Nice and easy, this one
Merged
Contributor
|
Great! thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.