TcSymbolUseData cleanup per #6084 #6089
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cartermp
changed the title
baronfel
force-pushed
the
tcsymbolusedata-cleanup
branch
2 times, most recently
from
031f1a8 to
5b96683
Compare
dsyme
requested changes
Jan 14, 2019
Contributor
dsyme
left a comment
dsyme
left a comment
There was a problem hiding this comment.
changes requested above. You don't need to add specific tests for this
dsyme
reviewed
Jan 14, 2019
Contributor
|
I checked the index logic, it's fine, suggested one improvement (but check it please! :) ) |
baronfel
force-pushed
the
tcsymbolusedata-cleanup
branch
from
5b96683 to
ed22216
Compare
Member
Author
|
Ok, I made the suggested changes, including special-casing zero-length ResizeArrays. |
dsyme
reviewed
Jan 14, 2019
dsyme
reviewed
Jan 14, 2019
Contributor
|
@baronfel Is this still WIP? (note: I changed the title earlier for when it still was) |
baronfel
changed the title
Member
Author
|
It's no longer WIP pending @dsyme accepting the changes made from his reviews. |
cartermp
reviewed
Jan 15, 2019
dsyme
approved these changes
Jan 17, 2019
rojepp
reviewed
Jan 17, 2019
TIHan
reviewed
Jan 17, 2019
TIHan
approved these changes
Jan 17, 2019
Contributor
TIHan
left a comment
TIHan
left a comment
There was a problem hiding this comment.
Looks good and a conservative approach.
Contributor
|
Thank you. |
11 tasks
auduchinok
added a commit
to auduchinok/fsharp
that referenced
this pull request
May 14, 2019
This reverts commit 7584974
auduchinok
added a commit
to auduchinok/fsharp
that referenced
this pull request
May 23, 2019
This reverts commit 7584974
auduchinok
added a commit
to auduchinok/fsharp
that referenced
this pull request
Sep 28, 2019
auduchinok
added a commit
to auduchinok/fsharp
that referenced
this pull request
Mar 3, 2020
auduchinok
added a commit
to auduchinok/fsharp
that referenced
this pull request
Apr 27, 2020
auduchinok
added a commit
to auduchinok/fsharp
that referenced
this pull request
Jun 9, 2020
auduchinok
added a commit
to auduchinok/fsharp
that referenced
this pull request
Jul 20, 2020
auduchinok
added a commit
to auduchinok/fsharp
that referenced
this pull request
Jul 27, 2020
auduchinok
added a commit
to auduchinok/fsharp
that referenced
this pull request
Oct 22, 2020
auduchinok
added a commit
to auduchinok/fsharp
that referenced
this pull request
Oct 28, 2020
auduchinok
added a commit
to auduchinok/fsharp
that referenced
this pull request
Dec 11, 2020
auduchinok
added a commit
to auduchinok/fsharp
that referenced
this pull request
Mar 5, 2021
This reverts commit 7584974.
auduchinok
added a commit
to auduchinok/fsharp
that referenced
this pull request
Apr 2, 2021
This reverts commit 7584974.
auduchinok
added a commit
to auduchinok/fsharp
that referenced
this pull request
May 17, 2021
This reverts commit 7584974.
auduchinok
added a commit
to auduchinok/fsharp
that referenced
this pull request
Jun 22, 2021
This reverts commit 7584974.
auduchinok
added a commit
to auduchinok/fsharp
that referenced
this pull request
Jul 12, 2021
This reverts commit 7584974.
auduchinok
added a commit
to auduchinok/fsharp
that referenced
this pull request
Jul 19, 2021
This reverts commit 7584974.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the start of fixing #6084 according to the suggestions in that thread about chunking the ResizeArray. I need to do testing locally as well but I'll have to boot up my windows machine and get a dev environment set up so it could take a minute.
I'm mostly putting this out to verify the approach/get CI validation as I continue working to clean it up and get to a good final solution.
TODO: