Dive into types in type test expressions in AST visitor traverse #5951
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Is it possible to add a test case for this? |
auduchinok
force-pushed
the
astVisitor-diveIntoTypes
branch
2 times, most recently
from
7428ef8 to
343ed6d
Compare
Member
Author
|
@TIHan Thanks, I added a test. |
auduchinok
force-pushed
the
astVisitor-diveIntoTypes
branch
from
343ed6d to
db7cf44
Compare
auduchinok
force-pushed
the
astVisitor-diveIntoTypes
branch
from
db7cf44 to
1130a55
Compare
TIHan
approved these changes
Dec 11, 2018
Contributor
TIHan
left a comment
TIHan
left a comment
There was a problem hiding this comment.
Thank you!
Seems CI is still failing though. When that is resolved, we can merge.
Contributor
|
Also, as a note, I am also lurking in changing some of this code to accomodate |
Member
Author
|
It's green. |
Contributor
|
@auduchinok Is there an issue to link here? No worries if there's no, I just want to associate something with a milestone for traceability. |
Member
Author
|
@cartermp No issue to link to, sorry. I pushed the fix right after discovering it. |
dsyme
approved these changes
Dec 13, 2018
Contributor
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
AstTraversal.Traversegoes intoexprparts of type test expressions only and ignorestypeparts. This PR adds diving intotypeparts.In the example below
System.Stringwill now be visited byVisitType.