Assembly reader shim #4915
Merged
Assembly reader shim #4915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auduchinok
force-pushed
the
assemblyReader
branch
from
d829772 to
2e37d3a
Compare
dsyme
requested changes
May 17, 2018
Contributor
dsyme
left a comment
dsyme
left a comment
There was a problem hiding this comment.
I'm ok with this change. Just one renaming change requested
src/absil/ilread.fsi
Outdated
|
|
||
|
|
||
| [<Sealed>] | ||
| type ILModuleReader = |
Contributor
There was a problem hiding this comment.
Just use the name ILModuleReader for the interface and hide this concrete implementation type please (I don't think it needs to be public?)
Re I naming - for example we already use ImportMap in the compiler even though it's an interface type.
Member
Author
|
This is ready. |
dsyme
approved these changes
May 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I extracted the assembly reader shim part from other changes introduced in #4791. Remaining changes are under discussion and will change in some way. If the reader part is OK, I'd rather have it merged.
@dsyme Would you mind having interface for ILModuleReader extracted?