Shortcut NameResolution searches #4444
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forki
force-pushed
the
shortcutnames
branch
2 times, most recently
from
c1868a0 to
bfce1c0
Compare
dsyme
requested changes
Mar 7, 2018
Contributor
dsyme
left a comment
dsyme
left a comment
There was a problem hiding this comment.
Looks good to me, I can see why you want to make the short-cut explicit.
One minor change - please do not use cascading indent and just align the default fall-through of the match.
src/fsharp/NameResolution.fs
Outdated
Contributor
There was a problem hiding this comment.
You don't have to indent the fallthrough branch of the match
Contributor
Author
|
done. |
KevinRansom
approved these changes
Mar 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.