Skip to content

List.isEmpty instead of iterating through the list to get the count #4439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 9, 2018
Merged

List.isEmpty instead of iterating through the list to get the count #4439

merged 1 commit into from
Mar 9, 2018

Conversation

@forki
Copy link
Contributor

@forki forki commented Mar 6, 2018

No description provided.

@dsyme
Copy link
Contributor

dsyme commented Mar 9, 2018

OK. I was going to say "In the compiler we have nonNil, please use that everywhere" but those got removed in a5f00ed.... :) Given the huge amount of list processing in the compiler I'm actually ok with having isNil and nonNil in lib.fs, but it's a separate thing I guess

@dsyme dsyme merged commit bbf07fb into dotnet:master Mar 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dsyme dsyme dsyme approved these changes

+1 more reviewer

@KevinRansom KevinRansom KevinRansom approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@forki @dsyme @KevinRansom