Skip to content

Conversation

@dsyme
Copy link
Contributor

@dsyme dsyme commented Feb 24, 2018

As part of #4368 I had to disable the FCS build on Jenkins Ubuntu due to Mono version. This should now be addressed since moving to Ubuntu 16.04

@dsyme
Copy link
Contributor Author

dsyme commented Feb 26, 2018

I ended up having to

  1. simplify a .NET-SDK a few more project files under fcs/samples
  2. find a solution for Build for desktop framework on non-windows platforms sdk#335 (where dotnet can't build .NET Framework projects out of the box on Linux/OSX - you can workaround by pointing it to the right reference assemblies).

The good news is that all of the following now work on both OSX and Windows (CI will test Linux) and all of them build/test/pack both netstandard2.0/netcoreapp2.0 and net45/net46.

dotnet restore fcs/FSharp.Compiler.Service.sln
dotnet build fcs/FSharp.Compiler.Service.sln
dotnet test fcs/FSharp.Compiler.Service.Tests/FSharp.Compiler.Service.Tests.fsproj
dotnet pack fcs/FSharp.Compiler.Service.sln

This means FCS testing and nuget packaging is now enabled and consistent across OSX and Windows.

@dsyme
Copy link
Contributor Author

dsyme commented Feb 27, 2018

@dotnet-bot Test Ubuntu16.04 Release_default Build please

@dsyme
Copy link
Contributor Author

dsyme commented Feb 27, 2018

WiIl merge, it's all fcs/...

@dsyme dsyme merged commit e7ce9cd into dotnet:master Feb 27, 2018
@forki
Copy link
Contributor

forki commented Feb 27, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants