Remove dependency on FSharp.LanguageService from FSharp.ProjectSystem #4385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@dotnet-bot test Ubuntu16.04 Release_default Build please |
Contributor
Author
|
@brettfo just wanted to say that I couldn't be happier to resolve these conflicts since there is SO MUCH being deleted from these icky project files 😄 |
Contributor
Author
|
ugh rebase sucked |
KevinRansom
approved these changes
Mar 1, 2018
Contributor
|
@dotnet-bot test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of the work in #4132
There was a lingering file,
UIThread.cs, in FSharp.LanguageService.Base that the legacy project system ultimately depended on. I just moved it to FSharp.ProjectSystem.Base.