Improve compiler designtime probing #4250
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DesignTime probing for typeproviders, searches the tfm subdrectory for an x86 and x64 subdirectory to load 32bit and 64 bit specific assemblies. This is not how nugget packages rid specific dll's it uses the runtime root of a nugget packat to store rid specific assemblies, and even allows them to be carried in separate nuget packages. We will need an improved probing design for that scenario.
Removes the x86 and x64 probing.
The F# compiler and FSI will also use the tools folder in the nuget package to host FSC/FCS/FSI designtime files. typeproviders cause packing warnings in nugget, and designtime assemblies are for more than just typeproviders.
Enables probing the tools folder of the nuget package.
Update tests to verify tools probing and eliminate tests for x96/x64 probing.