Improve warning for ignored values in sequence expressions - fixes #4228

[forki]

fixes #4228

[forki]

I used a new error number so that we can built quickfixes on top of it.

[vasily-kirichenko]

Please, add type of the ignored expressing into the warning message.

[forki]

good point.

[vasily-kirichenko]

Excellent, it's in conjunction with the recent Don's PR which added ignored type names into all warning messages.

[forki]

@dsyme this is weird:

src\fsharp\TypeChecker.fs(847,43): error FS0039: The field, constructor or member 'unitTypeExpectedInSequenceExpression' is not defined. 

for src\buildfromsource\FSharp.Compiler.Private\FSharp.Compiler.Private.fsproj in ci_part3 - but it's clearly there

[forki]

@vasily-kirichenko @dsyme another question: I see isListTy and isArrayty but no general isSeqTy. Do we have something like that for TType?

[forki]

@KevinRansom do you see by any chance why CI build 3 does not see the error message?

[KevinRansom]

Probably the way that text is converted to resources is not quite wired up the same. I will take a look later today.

[forki]

Thank you. Am 23.01.2018 20:39 schrieb "Kevin Ransom (msft)" <[email protected]

…

: Probably the way that text is converted to resources is not quite wired up the same. I will take a look later today. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#4245 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AADgNARuI3AnmunRucHE0Fe2zri0Uj35ks5tNjWCgaJpZM4RpTiz> .

[KevinRansom]

@forki Okay, I pushed a fix.

The reason this happened is because the build failed in the build from source projects. Those guys are for RedHat integration.

That build depends on released product, and the build task that converts from txt file to resx and generates the .fs file is not yet in the build of the dotnet cli that they use. Because of this, we just copy the transformed resx and .fs files. As soon as they update their base build tools we will modify the buildfrom source build to use the buildtask.

Sorry for the inconvenience ...

Kevin

[forki]

ok cool. so basically I need to touch these 2 files as well and things will be fine?

[KevinRansom]

@forki, yes, until the build from source uses a recent compiler, then it will be automagic like it should be.

[forki]

ok. this is done.

[cartermp]

ping @KevinRansom @dsyme for review

[dsyme]

Awesome work, thank you

It's possible a similar improvement could be made for async expressions?