Skip to content

only public sign assemblies, not test sign #3983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 21, 2017
Merged

only public sign assemblies, not test sign #3983

merged 1 commit into from
Nov 21, 2017
+34 −269

Conversation

@brettfo
Copy link
Member

@brettfo brettfo commented Nov 20, 2017

No description provided.

@brettfo
Copy link
Member Author

brettfo commented Nov 20, 2017

@dotnet-bot Windows_NT Release_ci_part3 Build please

@brettfo brettfo closed this Nov 20, 2017
@brettfo brettfo reopened this Nov 20, 2017
@brettfo
Copy link
Member Author

brettfo commented Nov 21, 2017

Also verified that build.cmd vs passes on a machine that's never disabled strong name verification for the delay signed assemblies.

@brettfo brettfo merged commit 949e1d4 into dotnet:master Nov 21, 2017
@brettfo brettfo deleted the no-test-sign branch November 21, 2017 18:27
@brettfo brettfo mentioned this pull request Nov 22, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@brettfo @KevinRansom @dsyme