Skip to content

Fix error range of wrong namespace in open declaration #3966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 20, 2017
Merged

Fix error range of wrong namespace in open declaration #3966

merged 1 commit into from
Nov 20, 2017

Conversation

@vasily-kirichenko
Copy link
Contributor

@vasily-kirichenko vasily-kirichenko commented Nov 17, 2017

This fixes #3934

image

image

cartermp
cartermp approved these changes Nov 17, 2017
View reviewed changes
Copy link
Contributor

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

KevinRansom
KevinRansom approved these changes Nov 20, 2017
View reviewed changes
Copy link
Contributor

@KevinRansom KevinRansom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you

@KevinRansom KevinRansom merged commit e0596f3 into dotnet:master Nov 20, 2017
@reinux
Copy link

reinux commented Nov 20, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@KevinRansom KevinRansom KevinRansom approved these changes

@cartermp cartermp cartermp approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Undefined namespace errors are misleading

4 participants

@vasily-kirichenko @reinux @KevinRansom @cartermp