Put nupkgs into artifacts #3806
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@forki ... shortly we are playing release train branch bingo right now. I will get both this and the fcs pr as soon as I can. |
KevinRansom
approved these changes
Oct 24, 2017
Contributor
Author
|
Can you please merge just this one for now then. Then pull requests of
other stakeholder like fable, ionide, rider, fake and Co. can actually
temporarily rebase on the other one and produce nupkg on CI to use fcs
custom builds downstream.
Am 24.10.2017 22:23 schrieb "Kevin Ransom (msft)" <[email protected]
:
*@KevinRansom* approved this pull request.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3806 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AADgNGbFmkS__pF8Zz6fd9oulbmgpZcKks5svkdbgaJpZM4QEKNS>
.
|
Contributor
Contributor
Author
|
Awesome. Thanks
Am 24.10.2017 22:29 schrieb "Kevin Ransom (msft)" <[email protected]
…:
As soon as this goes green and is merged : https://github.com/Microsoft/
visualfsharp/pull/3810
Will be less than an hour.
From: Steffen Forkmann ***@***.***
Sent: Tuesday, October 24, 2017 1:28 PM
To: Microsoft/visualfsharp ***@***.***>
Cc: Kevin Ransom ***@***.***>; Mention <
***@***.***>
Subject: Re: [Microsoft/visualfsharp] Put nupkgs into artifacts (#3806)
Can you please merge just this one for now then. Then pull requests of
other stakeholder like fable, ionide, rider, fake and Co. can actually
temporarily rebase on the other one and produce nupkg on CI to use fcs
custom builds downstream.
Am 24.10.2017 22:23 schrieb "Kevin Ransom (msft)" <
***@***.***
***@***.***%0b>>:
***@***.**** approved this pull request.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3806
pullrequestreview-71659645>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AADgNGbFmkS__
pF8Zz6fd9oulbmgpZcKks5svkdbgaJpZM4QEKNS>
.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<https://na01.safelinks.
protection.outlook.com/?url=https%3A%2F%2Fgithub.202132.xyz%
2FMicrosoft%2Fvisualfsharp%2Fpull%2F3806%23issuecomment-
339120624&data=02%7C01%7CKevin.Ransom%40microsoft.com%
7C26cce2906e1a49dd032108d51b1db17d%7C72f988bf86f141af91ab2d7cd011
db47%7C1%7C0%7C636444736709116035&sdata=1mdbdy7Mr4bB%
2FMnploQ1ptBMXJy85xz2rkttNhR%2F3mw%3D&reserved=0>, or mute the thread<
https://na01.safelinks.protection.outlook.com/?url=
https%3A%2F%2Fgithub.202132.xyz%2Fnotifications%2Funsubscribe-
auth%2FAE76Fm8x1xu49A_V4nz85eW7FWTof3VVks5svkhEgaJpZ
M4QEKNS&data=02%7C01%7CKevin.Ransom%40microsoft.com%
7C26cce2906e1a49dd032108d51b1db17d%7C72f988bf86f141af91ab2d7cd011
db47%7C1%7C0%7C636444736709116035&sdata=LoGF8YB6iYdF5FdH6Sx7LRpMn7H0TA
Y5swfn9MbQL0s%3D&reserved=0>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3806 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AADgNFtdFIHwAKmedY1XonmMGfIlXWgNks5svkilgaJpZM4QEKNS>
.
|
Contributor
|
thanks for this. |
KevinRansom
pushed a commit
that referenced
this pull request
Oct 26, 2017
KevinRansom
added a commit
that referenced
this pull request
Oct 27, 2017
* Merge dev15.5 to dev15.6 (#3825) * don't update project info if the source file collection is empty (#3792) * install templates VSIX to a unique directory (#3804) * P2p references (#3777) * P2p references * Fix test * test fix * go faster stripes * new project works better * Re-add debug assert for sourcefiles * Parameterise rc location (#3744) * Fix issues * Merge master to dev15.6 (#3826) * Put nupkgs into artifacts (#3806) * Make FCS build work on Jenkins (#3788)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @KevinRansom please merge