[WIP] Fix inlline rename at end of file #3766
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…because it causes loosing symbol occurrences in Inline Rename
Member
|
@dpoeschl or @jasonmalinowski Either of you have any idea? |
Member
|
Just clarifying: does this PR fix the behavior you're seeing (and we're trying to understand why) or fails to do so and we're still trying to understand what's wrong? |
Contributor
Author
|
@jasonmalinowski This PR does not fix the bug. |
Contributor
Author
|
This is how it works at the moment:
that is, the renaming itself works, but the preview (green spans) are wrong. |
Contributor
|
@dotnet-bot test this please |
dsyme
approved these changes
Jan 12, 2018
cartermp
approved these changes
Jan 12, 2018
Contributor
cartermp
left a comment
cartermp
left a comment
There was a problem hiding this comment.
Even though CI was busted previously, this worked for me when I used it. Thanks @vasily-kirichenko
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Jan 26, 2022
* do not filter symbol uses by range length in getSymbolUsesInSolution because it causes loosing symbol occurrences in Inline Rename * make impl closer to the XAML one * remove obsolete import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is how the editor looks (the bug):
This is how the preview looks (OK):
This is new document text in the debugger (OK):
The renaming works correctly as well (I mean it changes the document properly after committing).
So the only place where we have bad behavior is the green spans.
@Pilchie @dsyme Maybe it helps to narrow areas where the bug can sit? Thanks.