Skip to content

Do not commit autocompletion on bracket or pipe chars #3718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 14, 2017
Merged

Do not commit autocompletion on bracket or pipe chars #3718

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c25540b
Do not commit autocompletion on bracket or pipe chars
cartermp Oct 9, 2017
9d2e677
Remove accidentally added open statement
cartermp Oct 9, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions vsintegration/src/FSharp.Editor/Completion/CompletionProvider.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,23 @@ type internal FSharpCompletionProvider

let xmlMemberIndexService = serviceProvider.GetService(typeof<IVsXMLMemberIndexService>) :?> IVsXMLMemberIndexService
let documentationBuilder = XmlDocumentation.CreateDocumentationBuilder(xmlMemberIndexService, serviceProvider.DTE)

static let noCommitOnSpaceRules =
CompletionItemRules.Default.WithCommitCharacterRule(CharacterSetModificationRule.Create(CharacterSetModificationKind.Remove, ' ', '=', ',', '.', '<', '>', '(', ')', '!', ':'))
// These are important. They make sure we don't _commit_ autocompletion when people don't expect them to. Some examples:
//
// * type Foo() =
// member val a = 12 with get, <<---- Don't commit autocomplete!
//
// * type MyRecord = { name: <<---- Don't commit autocomplete!
//
// * type My< <<---- Don't commit autocomplete!
//
// * let myClassInstance = MyClass(Date= <<---- Don't commit autocomplete!
//
// * let xs = [1..10] <<---- Don't commit autocomplete! (same for arrays)
let noCommitChars = [|' '; '='; ','; '.'; '<'; '>'; '('; ')'; '!'; ':'; '['; ']'; '|'|].ToImmutableArray()

CompletionItemRules.Default.WithCommitCharacterRule(CharacterSetModificationRule.Create(CharacterSetModificationKind.Remove, noCommitChars))

static let getRules() = if Settings.IntelliSense.ShowAfterCharIsTyped then noCommitOnSpaceRules else CompletionItemRules.Default

Expand Down