Skip to content

Fix stack overflow on assembly resolution #3658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 29, 2017
+9 −1
Merged

Fix stack overflow on assembly resolution #3658

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c1f5c1
Fix stack overflow on tp assembly resolution
KevinRansom Sep 28, 2017
f32b00f
Feedback
KevinRansom Sep 28, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/utils/reshapedreflection.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,7 +327,15 @@ module internal ReflectionAdapters =
override this.Load (assemblyName:AssemblyName):Assembly =
this.LoadFromAssemblyName(assemblyName)

let globalLoadContext = new CustomAssemblyResolver()
let globalLoadContext =
// This is an unfortunate temporary fix!!!!
// ========================================
// We need to run fsi tests on a very old version of the corclr because of an unfortunate test framework
// This hack detects that, and uses the old code.
// On slightly newer code AssemblyLoadContext.Default is the way to go.
match Seq.tryHead (typeof<RuntimeTypeHandle>.GetTypeInfo().Assembly.GetCustomAttributes<AssemblyFileVersionAttribute>()) with
| Some a when a.Version = "4.6.24410.01" -> new CustomAssemblyResolver() :> AssemblyLoadContext
| _ -> AssemblyLoadContext.Default

#endif
type System.Reflection.Assembly with
Expand Down