Skip to content

Conversation

@KevinRansom
Copy link
Contributor

The Build logging displayed in the output window for an F# build was to say the least idiosyncratic.

This PR addresses that by producing in IDE logging that more closely aligns with the definitions of:

  • Minimal
  • Normal
  • Detailed
  • Diagnostic.

@dsyme
Copy link
Contributor

dsyme commented Sep 20, 2017

We have this failure, which looks unrelated, but we shuold work out what's caused it

1) Failed : Tests.LanguageService.Script.UsingProjectSystem.TypeProvider.Disposal.SmokeTest2
  Check1, countDisposals() < i, iteration 1
  Expected: True
  But was:  False
at Tests.LanguageService.Script.UsingMSBuild.TypeProviderDisposalSmokeTest(Boolean clearing) in D:\j\workspace\release_ci_pa---3f142ccc\vsintegration\tests\unittests\Tests.LanguageService.Script.fs:line 1625
at Tests.LanguageService.Script.UsingMSBuild.TypeProvider.Disposal.SmokeTest2() in D:\j\workspace\release_ci_pa---3f142ccc\vsintegration\tests\unittests\Tests.LanguageService.Script.fs:line 1662

@dsyme
Copy link
Contributor

dsyme commented Sep 20, 2017

@dotnet-bot test Windows_NT Release_ci_part1 Build please

@dsyme dsyme merged commit 907e113 into dotnet:master Sep 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants