Skip to content

Fix for: 3596 --- [.NET Framework Projects] IDE is confused about the last file to compile #3603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 19, 2017
Merged

Fix for: 3596 --- [.NET Framework Projects] IDE is confused about the last file to compile #3603

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions vsintegration/src/FSharp.Editor/LanguageService/LanguageService.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,9 +273,13 @@ type internal FSharpProjectOptionsManager
}

member this.UpdateProjectInfoWithProjectId(projectId:ProjectId, userOpName) =
Copy link
Contributor

@dsyme dsyme Sep 19, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should systematically clarify between "LegacyProject" and "ModernProject" throughout the naming of method like this, so

UpdateProjectInfoWithProjectId --> UpdateModernProjectInfoWithProjectId 
SetupProject --> SetupLegacyProject

etc. That may help us reason correctly about the two separate paths

let project = workspace.CurrentSolution.GetProject(projectId)
let siteProvider = this.ProvideProjectSiteProvider(project)
this.UpdateProjectInfo(tryGetOrCreateProjectId, projectId, siteProvider.GetProjectSite(), userOpName)
let hier = workspace.GetHierarchy(projectId)
match hier with
| h when (h.IsCapabilityMatch("CPS")) ->
let project = workspace.CurrentSolution.GetProject(projectId)
let siteProvider = this.ProvideProjectSiteProvider(project)
this.UpdateProjectInfo(tryGetOrCreateProjectId, projectId, siteProvider.GetProjectSite(), userOpName)
| _ -> ()

member this.UpdateProjectInfoWithPath(path, userOpName) =
let projectId = workspace.ProjectTracker.GetOrCreateProjectIdForPath(path, projectDisplayNameOf path)
Expand Down