Skip to content

typeof in quotations.fs now respects ByRef types #3450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 17, 2017
Merged

typeof in quotations.fs now respects ByRef types #3450

merged 2 commits into from
Oct 17, 2017

Conversation

@krauthaufen
Copy link
Contributor

@krauthaufen krauthaufen commented Aug 17, 2017

When using AddressOf in quotations typeof function simple threw an exception which makes it impossible to call methods using byref-arguments.

Since there is a .NET-representation for byref-types why not use it?

forki
forki reviewed Aug 17, 2017
View reviewed changes
Copy link
Contributor

@forki forki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the remaining case still give that specific error message?

@krauthaufen
Copy link
Contributor Author

krauthaufen commented Aug 17, 2017

Shouldn't AddressOf contain one sub-expression only?

@dsyme
Copy link
Contributor

dsyme commented Aug 17, 2017

@krauthaufen Could you add a test too please? See src\fsharp\FSharp.Core.Unittests

dsyme
dsyme requested changes Aug 17, 2017
View reviewed changes
Copy link
Contributor

@dsyme dsyme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requested a test be added

@KevinRansom
Copy link
Contributor

KevinRansom commented Aug 29, 2017

@krauthaufen Hi, thanks for this PR, did you notice Don's comment?

@dotnet dotnet deleted a comment from msftclas Sep 26, 2017
@dsyme dsyme mentioned this pull request Oct 4, 2017
Closed
@dsyme
Copy link
Contributor

dsyme commented Oct 4, 2017

@krauthaufen could you add a test for this please? Many thanks

@krauthaufen
Copy link
Contributor Author

krauthaufen commented Oct 4, 2017

Hi, sorry for the late response. i will look into it tomorrow.

@dsyme
Copy link
Contributor

dsyme commented Oct 4, 2017

@krauthaufen Great! See tests\fsharp\core\quotes\test.fsx?

@krauthaufen
[Test] added tests for AddressOf quotations
6706929 
- AddressOf now has a proper type (byref<'a>)
- AddressOf can be used in Expr.Call (was an error)
- calls containing AddressOf can be rebuilt using RebuildShapeCombination
@msftclas
Copy link

msftclas commented Oct 5, 2017 •
edited
Loading

CLA assistant check
All CLA requirements met.

@krauthaufen
Copy link
Contributor Author

krauthaufen commented Oct 5, 2017

@dsyme I just added a few tests checking that AddressOf can now be used as argument to Expr.Call(...), etc.
This was failing due to the exception in typeof.
Couldn't really think of more cases where this change affects anything :-)

@KevinRansom KevinRansom merged commit e5762fd into dotnet:master Oct 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dsyme dsyme dsyme approved these changes

+2 more reviewers

@forki forki forki left review comments

@KevinRansom KevinRansom KevinRansom approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@krauthaufen @dsyme @KevinRansom @msftclas @forki @msftgits