Document project options and mark lots of things as deprecated #3449
Conversation
|
This also detected a case where we were using the old FSharp.LanguageService.dll XMLDocumentation formatter. Some unit tests may fail since I changed over to use the FSharp.Editor.dll version of that code. The old code can now be deleted |
|
Re: xmldocumentaiton - yeah, I think I didn't move the tests over to just use the one in FSharp.Editor on account of some rabbit hole involve all sorts of things just failing to compile. The task of moving test code that tests FSharp.LanguageService code over to the FSharp.Editor equivalents is going to be a task involving lots and lots of file changes. |
Yes, it's a vast job. I'm not sure when/if we will ever get to it. Fortunately it feels like we have enough smoke tests for the FSharp.Editor functionality, and the extra checking of F# compiler code via these deprecated paths gives good coverage |
* Document project options and mark lots of things as deprecated (#3449) * Document project options and mark lots of things as deprecated * delete some code that is no longer used * fix packaging of FSharp.Core. (#3452) * implement IDisposable interfaces explicitly (#3447) * added IDisposable * reverted Dispose change * ngen open source install (#3456) * handle "Blue (high contrast)" theme (#3443)
…t#3449) * Document project options and mark lots of things as deprecated * delete some code that is no longer used
* Document project options and mark lots of things as deprecated (dotnet#3449) * Document project options and mark lots of things as deprecated * delete some code that is no longer used * fix packaging of FSharp.Core. (dotnet#3452) * implement IDisposable interfaces explicitly (dotnet#3447) * added IDisposable * reverted Dispose change * ngen open source install (dotnet#3456) * handle "Blue (high contrast)" theme (dotnet#3443)
3 participants
@KevinRansom was asking how the project processing code worked. I went through and made some notes about my understanding of it. The new F# project system should provide us with a correct roslyn Project and should be simpler
I also went through and marked a whole lot of old code as "deprecated, used in unroslynized unittests only, delete once tests have been roslynized".
p.s. So "unroslynized" is now a word