fix span bug #3180 #3181
Merged
fix span bug #3180 #3181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cartermp
approved these changes
Jun 6, 2017
Contributor
cartermp
left a comment
cartermp
left a comment
There was a problem hiding this comment.
Code looks fine and I like the move to TryFSharpRangeToTextSpan being ubiquitous.
KevinRansom
approved these changes
Jun 6, 2017
KevinRansom
approved these changes
Jun 6, 2017
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a stabilization fix to ensure that problems with spans are not catastrophic
See #3180
The technique is simply to use the "Try" version of the FSharpRangeToTextSpan function everywhere, and to make FSharpRangeToTextSpan itself fail less often, trimming to the range of the document