-
Notifications
You must be signed in to change notification settings - Fork 830
[WIP] Manofstick seq composer squashed #2526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
smoothdeveloper
wants to merge
59
commits into
dotnet:master
from
smoothdeveloper:manofstick-seq-composer-squashed
Closed
Changes from all commits
Commits
Show all changes
59 commits
Select commit
Hold shift + click to select a range
9e06b15
Basis of SeqComposer
manofstick 6e6129b
renaming cleanup. Adding ListEnumerable. Adding Choose
liboz d158bbb
Remove unbox.any when upcasting to IEnumer(able|ator)
manofstick babf7b4
remove old mapi function
liboz c312614
Changes SeqComposer to build bottom-up
manofstick c05e22a
fix typo
liboz f0f74e4
Carry on disposing under exceptions
manofstick 701fc83
distinct/distinctby
liboz d7c26d1
Seq.append
manofstick e0d78fd
zip/zip3
liboz 82aa192
Made map2 more complex (reverted from commit ceaed6cd7cb9f842fb9b4744…
liboz 459d3db
Seq.ofArray
manofstick 65f9c84
making identity more efficient
liboz 18fd79a
sumby, average, averageby, max, maxby, min, minby
liboz b8e94bf
Removed overzelous upcastSeqConsumer
manofstick db169c2
toComposer and implementing sum
liboz 4e3eb41
Remove duplicated ISeqPipeline
manofstick f5918c1
Seq.iteri, exists, contains, forall, trypick, pick, tryfind, find, re…
liboz 67abac1
Made names a little less verbose
manofstick 873caa5
findIndex/tryFindIndex
liboz 5d1d0ed
Fix a Take bug
manofstick 9c21042
Seq.scan
liboz 99e17ea
Another take on halting index
manofstick 6d13d09
seq.comparewith
liboz 438b180
More compact Seq.compareWith
manofstick 0594870
Seq.item/iter2/iteri2/fold2/forall2/exists2
liboz eb58a37
Removed Helpers. qualifier
manofstick 617c72c
seq.windowed
liboz 392f3e7
Tightening up Seq.windowed
manofstick c5ae38a
Reduce the diff on seq.fs so that it is easier to review on GitHub
liboz 302402b
Remove Helper from signature file
manofstick 69753d0
Made map2 more complex (reverted from commit ceaed6cd7cb9f842fb9b4744…
liboz 19c1233
Seq.ofArray
manofstick a5f12d7
making identity more efficient
liboz 4b63756
Updated NoNeedToTailcall for Seq.iter changes
manofstick 73e810f
sumby, average, averageby, max, maxby, min, minby
liboz bc9dacf
Removed overzelous upcastSeqConsumer
manofstick 5bb660d
toComposer and implementing sum
liboz 2654820
Remove duplicated ISeqPipeline
manofstick ef8364b
Seq.iteri, exists, contains, forall, trypick, pick, tryfind, find, re…
liboz ada1435
Made names a little less verbose
manofstick 807121c
findIndex/tryFindIndex
liboz 45a64e6
Fix a Take bug
manofstick 7e126de
Another take on halting index
manofstick b2cda99
seq.comparewith
liboz f1ac6bd
More compact Seq.compareWith
manofstick 9e3f753
Seq.item/iter2/iteri2/fold2/forall2/exists2
liboz a134bf8
Removed Helpers. qualifier
manofstick a7dc52c
seq.windowed
liboz ec3af9d
Tightening up Seq.windowed
manofstick a038513
Reduce the diff on seq.fs so that it is easier to review on GitHub
liboz 3f0cccc
Remove Helper from signature file
manofstick 7ba76b4
inline choose
cloudRoutine 8f8e280
Simplified OnComplete/OnDispose
manofstick 80fc59e
remove parens
cloudRoutine 5fa4235
Removed ICompletionChain
manofstick e7409fe
fix compile issue
smoothdeveloper f6d259d
Syncing with my repository after rebase
manofstick cecb26e
adjust seq tests for better filering and sorting
cloudRoutine File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
5 changes: 4 additions & 1 deletion
5
...p.Core.Unittests/FSharp.Core/Microsoft.FSharp.Collections/CollectionModulesConsistency.fs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I personally like the simpler
moduleandletsyntax, but I think we should do this as a seperate PR, as @dsyme has said on a number of occasions that he would prefer minimum changes so as to limit as much scope of review as possible.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was a basic usability change so that it;d be easy to run the necessary tests in the VS Test Runner, as they are currently setup it's hard to select the right ones. We can remove that commit later if Don doesn't like it, but for now it's useful