Manofstick seq composer / rebased #2525
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implemention performs vastly better than the previous implementation, which appeared to be more interested in being theoretically important than actually being a reasonable implementation. Anyway, the previous version blew up with stack overflow if you appended too many things, which the new version doesn't.
This is retained for compatibility
- better comments - consistent casing
- removing the check of both types
Identity can be used to wrap basic containers into SeqComposer compatible types, but can safely be removed when composing the components.
Also removed some extra null checks
The use of lazy changed the seq's funcitonality, as it would have only been calculated once, even if the sequence was iterated again.
Currently this is only implemented on Array. This adds some public surface to the SeqComposer which may be removed.
- via struct interface (i.e. inline at runtime) - basically speed parity for sum
- the didn't really serve any purpose
- Made management of it part of the ISeq classes - Removed internal Build function as well
- didn't really consume anything - removed helper classes to slightly decrease surface area
- Moved SR.GetString code into Composer
- and finally decided to just go with Transform as the general name for processing
- For symmetry with Folder - Fixed a spelling error
- SeqFactory to TransformFactory - Compose to PushTransform - Create to Compose
- And removed unbox cast for performance
- also renamed delayed as delay to match seq
sorts/rev/permute
- and moved creating Value comparer to a helper function
- more consistency formatting
Contributor
Author
|
closing this one in favor of squashed one (#2526). I've gaven @manofstick / @liboz / @cloudRoutine access to my fork if they want to keep integrating in it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took always the seq composer side on conflicts, and had to fix a manual compile (see last commit).
this obviously need carefull review, I'd recommend people who worked on that PR to take history of fsharp.core since the last rebase of the original PR and review if each commit done has been caried over.