Fix for #2373 #2404
Merged
Fix for #2373 #2404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillHally
reviewed
Feb 11, 2017
Contributor
BillHally
left a comment
BillHally
left a comment
There was a problem hiding this comment.
Thanks for this.
You could combine the test you make in the "if" clause with the existing "when" clause, and then you wouldn't need to duplicate the code in the "else" clause and the outermost "_" match case.
KevinRansom
approved these changes
Feb 13, 2017
Contributor
|
@liboz Any chance we could add a regression test, to ensure we keep it working? Kevin |
Contributor
Author
|
I'm not sure how to add a test that uses peverify because the weird thing about this case is that the compilation step works for the broken code, but it fails peverify. |
Contributor
|
@liboz I believe there are many tests that compile and peverify, search the codebase. |
Contributor
Contributor
Author
|
@vasily-kirichenko @dsyme Thanks for pointing me in the right direction. |
Contributor
|
@liboz |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to fix #2373