Skip to content

Show Add Open code fix if the unresolved symbol is in the middle of the long ident #2166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 5, 2017
Merged

Show Add Open code fix if the unresolved symbol is in the middle of the long ident #2166

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/fsharp/vs/ServiceAssemblyContent.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -467,9 +467,9 @@ module internal Entity =
| _ ->
partiallyQualifiedName
|> Array.heads
// the last part must be unresolved, otherwise we show false positive suggestions like
// long ident must contain an unresolved part, otherwise we show false positive suggestions like
// "open System" for `let _ = System.DateTime.Naaaw`. Here only "Naaw" is unresolved.
|> Array.filter (fun x -> not (x.[x.Length - 1].Resolved))
|> Array.filter (fun x -> x |> Array.exists (fun x -> not x.Resolved))
|> Array.choose (fun parts ->
let parts = parts |> Array.map (fun x -> x.Ident)
if not (candidate |> Array.endsWith parts) then None
Expand Down