Skip to content

Create better error message when implementing an interface with overloads #1907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 16, 2016
Merged

Create better error message when implementing an interface with overloads #1907

merged 3 commits into from
Dec 16, 2016

Conversation

@forki
Copy link
Contributor

@forki forki commented Dec 1, 2016 •
edited
Loading

fixes #1905

image

  • add test
  • emit new error message with new error code
  • fix all test that we broke

@forki forki mentioned this pull request Dec 1, 2016
Closed
@forki
Copy link
Contributor Author

forki commented Dec 1, 2016

I think this is not the correct way. Working on a better fix

@forki forki force-pushed the i1905 branch 2 times, most recently from 07f915e to 6594d9e Compare December 2, 2016 07:41
@forki forki closed this Dec 5, 2016
@forki forki reopened this Dec 5, 2016
@forki forki force-pushed the i1905 branch 4 times, most recently from f16a8bb to 5dd2c03 Compare December 6, 2016 13:05
@forki forki changed the title WIP Create better error message when implementing an interface with overloads Create better error message when implementing an interface with overloads Dec 6, 2016
@forki
Copy link
Contributor Author

forki commented Dec 6, 2016

apart from that general CI issues this is now ready for review

@forki forki force-pushed the i1905 branch 2 times, most recently from dff5477 to b1438b5 Compare December 8, 2016 15:25
@KevinRansom
Copy link
Contributor

KevinRansom commented Dec 14, 2016

@dotnet-bot test this please

@forki
Copy link
Contributor Author

forki commented Dec 16, 2016

@KevinRansom rebased on master. ready to go in

@KevinRansom KevinRansom merged commit 03cdfb0 into dotnet:master Dec 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@KevinRansom KevinRansom KevinRansom approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Confusing and ambiguous error (FS0368) when implementing an interface with overloads

3 participants

@forki @KevinRansom @msftclas