Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/release-notes/.FSharp.Compiler.Service/10.0.100.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
* Fix Show XML doc for enum fields in external metadata ([Issue #17939](https://github.com/dotnet/fsharp/issues/17939#issuecomment-3137410105), [PR #18800](https://github.com/dotnet/fsharp/pull/18800))
* Fix nullable types formatting in `FSharpType.Format` and tooltips to include parentheses. ([PR #18842](https://github.com/dotnet/fsharp/pull/18842))
* TypeMismatchDiagnosticExtendedData: fix expected and actual types calculation. ([Issue ](https://github.com/dotnet/fsharp/pull/18851))
* Parser: fix range for computed binding expressions ([PR #18903](https://github.com/dotnet/fsharp/pull/18903))

### Changed
* Use `errorR` instead of `error` in `CheckDeclarations.fs` when possible. ([PR #18645](https://github.com/dotnet/fsharp/pull/18645))
Expand Down
2 changes: 1 addition & 1 deletion src/Compiler/SyntaxTree/ParseHelpers.fs
Original file line number Diff line number Diff line change
Expand Up @@ -1105,7 +1105,7 @@ let mkLetExpression
headPat = pat,
returnInfo = None,
expr = rhs,
range = mWhole,
range = unionRanges mKeyword rhs.Range,
debugPoint = spBind,
trivia = trivia
)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ ImplFile
App
(NonAtomic, false, Ident getBar,
Const (Unit, (3,22--3,24)), (3,15--3,24)),
(3,4--6,14), Yes (3,4--3,24),
(3,4--3,24), Yes (3,4--3,24),
{ LeadingKeyword = Let (3,4--3,8)
InlineKeyword = None
EqualsRange = Some (3,13--3,14) });
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ ImplFile
App
(NonAtomic, false, Ident getBar,
Const (Unit, (3,22--3,24)), (3,15--3,24)),
(3,4--7,14), Yes (3,4--3,24),
(3,4--3,24), Yes (3,4--3,24),
{ LeadingKeyword = Let (3,4--3,8)
InlineKeyword = None
EqualsRange = Some (3,13--3,14) });
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ ImplFile
SynValInfo ([], SynArgInfo ([], false, None)),
None),
Named (SynIdent (x, None), false, None, (3,9--3,10)),
None, Ident y, (3,4--5,13), Yes (3,4--3,14),
None, Ident y, (3,4--3,14), Yes (3,4--3,14),
{ LeadingKeyword = Let (3,4--3,8)
InlineKeyword = None
EqualsRange = Some (3,11--3,12) });
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ ImplFile
((false, true), Const (Int32 1, (4,35--4,36)),
(4,28--4,36),
{ YieldOrReturnKeyword = (4,28--4,34) }),
(4,26--4,38)), (4,20--4,38)), (4,4--5,14),
(4,26--4,38)), (4,20--4,38)), (4,4--4,38),
Yes (4,4--4,38), { LeadingKeyword = Let (4,4--4,8)
InlineKeyword = None
EqualsRange = Some (4,18--4,19) })],
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ ImplFile
((false, true), Const (Int32 1, (4,37--4,38)),
(4,30--4,38),
{ YieldOrReturnKeyword = (4,30--4,36) }),
(4,28--4,40)), (4,22--4,40)), (4,4--5,14),
(4,28--4,40)), (4,22--4,40)), (4,4--4,40),
Yes (4,4--4,40), { LeadingKeyword = Let (4,4--4,8)
InlineKeyword = None
EqualsRange = Some (4,20--4,21) })],
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ ImplFile
[(5,44--5,45)], (5,43--5,47)),
(5,36--5,47),
{ YieldOrReturnKeyword = (5,36--5,42) }),
(5,34--5,49)), (5,28--5,49)), (5,4--6,24),
(5,34--5,49)), (5,28--5,49)), (5,4--5,49),
Yes (5,4--5,49),
{ LeadingKeyword = Let (5,4--5,8)
InlineKeyword = None
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ ImplFile
((false, true), Const (Int32 1, (2,28--2,29)),
(2,21--2,29),
{ YieldOrReturnKeyword = (2,21--2,27) }),
(2,19--2,31)), (2,13--2,31)), (2,0--3,33),
(2,19--2,31)), (2,13--2,31)), (2,0--2,31),
Yes (2,0--2,31), { LeadingKeyword = Let (2,0--2,4)
InlineKeyword = None
EqualsRange = Some (2,11--2,12) })],
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ ImplFile
((false, true), Const (Int32 1, (2,28--2,29)),
(2,21--2,29),
{ YieldOrReturnKeyword = (2,21--2,27) }),
(2,19--2,31)), (2,13--2,31)), (2,0--3,33),
(2,19--2,31)), (2,13--2,31)), (2,0--2,31),
Yes (2,0--2,31), { LeadingKeyword = Let (2,0--2,4)
InlineKeyword = None
EqualsRange = Some (2,11--2,12) })],
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ ImplFile
App
(Atomic, false, Ident asyncPerson,
Const (Unit, (3,48--3,50)), (3,37--3,50)),
(3,4--5,15), Yes (3,4--3,50),
(3,4--3,50), Yes (3,4--3,50),
{ LeadingKeyword = Let (3,4--3,8)
InlineKeyword = None
EqualsRange = Some (3,35--3,36) })],
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ ImplFile
App
(Atomic, false, Ident asyncPerson,
Const (Unit, (3,46--3,48)), (3,35--3,48)),
(3,4--4,15), Yes (3,4--3,48),
(3,4--3,48), Yes (3,4--3,48),
{ LeadingKeyword = Let (3,4--3,8)
InlineKeyword = None
EqualsRange = Some (3,33--3,34) })],
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ ImplFile
App
(Atomic, false, Ident asyncOption,
Const (Unit, (3,36--3,38)), (3,25--3,38)),
(3,4--4,16), Yes (3,4--3,38),
(3,4--3,38), Yes (3,4--3,38),
{ LeadingKeyword = Let (3,4--3,8)
InlineKeyword = None
EqualsRange = Some (3,23--3,24) })],
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ ImplFile
App
(Atomic, false, Ident asyncOption,
Const (Unit, (3,34--3,36)), (3,23--3,36)),
(3,4--4,16), Yes (3,4--3,36),
(3,4--3,36), Yes (3,4--3,36),
{ LeadingKeyword = Let (3,4--3,8)
InlineKeyword = None
EqualsRange = Some (3,21--3,22) })],
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ ImplFile
App
(Atomic, false, Ident asyncOption,
Const (Unit, (3,48--3,50)), (3,37--3,50)),
(3,4--4,16), Yes (3,4--3,50),
(3,4--3,50), Yes (3,4--3,50),
{ LeadingKeyword = Let (3,4--3,8)
InlineKeyword = None
EqualsRange = Some (3,35--3,36) })],
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ ImplFile
App
(Atomic, false, Ident asyncOption,
Const (Unit, (3,46--3,48)), (3,35--3,48)),
(3,4--4,16), Yes (3,4--3,48),
(3,4--3,48), Yes (3,4--3,48),
{ LeadingKeyword = Let (3,4--3,8)
InlineKeyword = None
EqualsRange = Some (3,33--3,34) })],
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ ImplFile
App
(Atomic, false, Ident asyncInt,
Const (Unit, (4,29--4,31)), (4,21--4,31)),
(4,4--6,16), Yes (4,4--4,31),
(4,4--4,31), Yes (4,4--4,31),
{ LeadingKeyword = Let (4,4--4,8)
InlineKeyword = None
EqualsRange = Some (4,19--4,20) });
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ ImplFile
App
(Atomic, false, Ident asyncString,
Const (Unit, (5,39--5,41)), (5,28--5,41)),
(4,4--6,16), Yes (4,4--5,41),
(4,4--5,41), Yes (4,4--5,41),
{ LeadingKeyword = Let (4,4--4,8)
InlineKeyword = None
EqualsRange = Some (5,26--5,27) })],
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ ImplFile
Const (Int32 2, (5,43--5,44)),
(5,36--5,44),
{ YieldOrReturnKeyword = (5,36--5,42) }),
(5,34--5,46)), (5,28--5,46)), (5,4--6,12),
(5,34--5,46)), (5,28--5,46)), (5,4--5,46),
Yes (5,4--5,46),
{ LeadingKeyword = Let (5,4--5,8)
InlineKeyword = None
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ ImplFile
Const (Int32 2, (5,41--5,42)),
(5,34--5,42),
{ YieldOrReturnKeyword = (5,34--5,40) }),
(5,32--5,44)), (5,26--5,44)), (5,4--6,12),
(5,32--5,44)), (5,26--5,44)), (5,4--5,44),
Yes (5,4--5,44),
{ LeadingKeyword = Let (5,4--5,8)
InlineKeyword = None
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ ImplFile
((false, true), Const (Int32 1, (4,35--4,36)),
(4,28--4,36),
{ YieldOrReturnKeyword = (4,28--4,34) }),
(4,26--4,38)), (4,20--4,38)), (4,4--6,14),
(4,26--4,38)), (4,20--4,38)), (4,4--4,38),
Yes (4,4--4,38), { LeadingKeyword = Let (4,4--4,8)
InlineKeyword = None
EqualsRange = Some (4,18--4,19) });
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ ImplFile
((false, true), Const (Int32 1, (4,37--4,38)),
(4,30--4,38),
{ YieldOrReturnKeyword = (4,30--4,36) }),
(4,28--4,40)), (4,22--4,40)), (4,4--6,14),
(4,28--4,40)), (4,22--4,40)), (4,4--4,40),
Yes (4,4--4,40), { LeadingKeyword = Let (4,4--4,8)
InlineKeyword = None
EqualsRange = Some (4,20--4,21) });
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ ImplFile
App
(Atomic, false, Ident asyncPerson,
Const (Unit, (4,59--4,61)), (4,48--4,61)),
(4,4--6,15), Yes (4,4--4,61),
(4,4--4,61), Yes (4,4--4,61),
{ LeadingKeyword = Let (4,4--4,8)
InlineKeyword = None
EqualsRange = Some (4,46--4,47) });
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ ImplFile
App
(Atomic, false, Ident asyncPerson,
Const (Unit, (4,57--4,59)), (4,46--4,59)),
(4,4--6,15), Yes (4,4--4,59),
(4,4--4,59), Yes (4,4--4,59),
{ LeadingKeyword = Let (4,4--4,8)
InlineKeyword = None
EqualsRange = Some (4,44--4,45) });
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ ImplFile
App
(Atomic, false, Ident asyncPerson,
Const (Unit, (4,59--4,61)), (4,48--4,61)),
(4,4--6,15), Yes (4,4--4,61),
(4,4--4,61), Yes (4,4--4,61),
{ LeadingKeyword = Let (4,4--4,8)
InlineKeyword = None
EqualsRange = Some (4,46--4,47) });
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ ImplFile
App
(Atomic, false, Ident asyncOption,
Const (Unit, (4,36--4,38)), (4,25--4,38)),
(4,4--6,25), Yes (4,4--4,38),
(4,4--4,38), Yes (4,4--4,38),
{ LeadingKeyword = Let (4,4--4,8)
InlineKeyword = None
EqualsRange = Some (4,23--4,24) });
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ ImplFile
App
(Atomic, false, Ident asyncOption,
Const (Unit, (4,34--4,36)), (4,23--4,36)),
(4,4--6,25), Yes (4,4--4,36),
(4,4--4,36), Yes (4,4--4,36),
{ LeadingKeyword = Let (4,4--4,8)
InlineKeyword = None
EqualsRange = Some (4,21--4,22) });
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ ImplFile
App
(Atomic, false, Ident asyncOption,
Const (Unit, (4,48--4,50)), (4,37--4,50)),
(4,4--6,25), Yes (4,4--4,50),
(4,4--4,50), Yes (4,4--4,50),
{ LeadingKeyword = Let (4,4--4,8)
InlineKeyword = None
EqualsRange = Some (4,35--4,36) });
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ ImplFile
App
(Atomic, false, Ident asyncOption,
Const (Unit, (4,46--4,48)), (4,35--4,48)),
(4,4--6,25), Yes (4,4--4,48),
(4,4--4,48), Yes (4,4--4,48),
{ LeadingKeyword = Let (4,4--4,8)
InlineKeyword = None
EqualsRange = Some (4,33--4,34) });
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ ImplFile
App
(Atomic, false, Ident asyncInt,
Const (Unit, (4,33--4,35)), (4,25--4,35)),
(4,4--6,16), Yes (4,4--4,35),
(4,4--4,35), Yes (4,4--4,35),
{ LeadingKeyword = Let (4,4--4,8)
InlineKeyword = None
EqualsRange = Some (4,23--4,24) });
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ ImplFile
App
(Atomic, false, Ident asyncInt,
Const (Unit, (4,31--4,33)), (4,23--4,33)),
(4,4--6,16), Yes (4,4--4,33),
(4,4--4,33), Yes (4,4--4,33),
{ LeadingKeyword = Let (4,4--4,8)
InlineKeyword = None
EqualsRange = Some (4,21--4,22) });
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ ImplFile
App
(Atomic, false, Ident asyncInt,
Const (Unit, (4,26--4,28)), (4,18--4,28)),
(4,4--6,16), Yes (4,4--4,28),
(4,4--4,28), Yes (4,4--4,28),
{ LeadingKeyword = Let (4,4--4,8)
InlineKeyword = None
EqualsRange = Some (4,16--4,17) });
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ ImplFile
App
(Atomic, false, Ident asyncArray,
Const (Unit, (4,54--4,56)), (4,44--4,56)),
(4,4--6,16), Yes (4,4--4,56),
(4,4--4,56), Yes (4,4--4,56),
{ LeadingKeyword = Let (4,4--4,8)
InlineKeyword = None
EqualsRange = Some (4,42--4,43) });
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ ImplFile
App
(Atomic, false, Ident asyncArray,
Const (Unit, (4,52--4,54)), (4,42--4,54)),
(4,4--6,16), Yes (4,4--4,54),
(4,4--4,54), Yes (4,4--4,54),
{ LeadingKeyword = Let (4,4--4,8)
InlineKeyword = None
EqualsRange = Some (4,40--4,41) });
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ ImplFile
App
(Atomic, false, Ident asyncInt,
Const (Unit, (4,37--4,39)), (4,29--4,39)),
(4,4--5,16), Yes (4,4--4,39),
(4,4--4,39), Yes (4,4--4,39),
{ LeadingKeyword = Let (4,4--4,8)
InlineKeyword = None
EqualsRange = Some (4,27--4,28) })],
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ ImplFile
App
(Atomic, false, Ident asyncInt,
Const (Unit, (4,37--4,39)), (4,29--4,39)),
(4,4--6,13), Yes (4,4--4,39),
(4,4--4,39), Yes (4,4--4,39),
{ LeadingKeyword = Let (4,4--4,8)
InlineKeyword = None
EqualsRange = Some (4,27--4,28) });
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ ImplFile
App
(Atomic, false, Ident asyncInt,
Const (Unit, (4,37--4,39)), (4,29--4,39)),
(4,4--6,13), Yes (4,4--4,39),
(4,4--4,39), Yes (4,4--4,39),
{ LeadingKeyword = Let (4,4--4,8)
InlineKeyword = None
EqualsRange = Some (4,27--4,28) });
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ ImplFile
App
(Atomic, false, Ident asyncInt,
Const (Unit, (4,33--4,35)), (4,25--4,35)),
(4,4--6,16), Yes (4,4--4,35),
(4,4--4,35), Yes (4,4--4,35),
{ LeadingKeyword = Let (4,4--4,8)
InlineKeyword = None
EqualsRange = Some (4,23--4,24) });
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ ImplFile
None),
Named
(SynIdent (a, None), false, None, (6,9--6,10)),
None, Const (Int32 3, (6,13--6,14)), (6,4--8,13),
None, Const (Int32 3, (6,13--6,14)), (6,4--6,14),
Yes (6,4--6,14),
{ LeadingKeyword = Let (6,4--6,8)
InlineKeyword = None
Expand Down
Loading
Loading