Show external metadata for enum fields in decompiled view

[ThobiWanKenobi]

Description

This PR enables displaying external metadata for enum fields in the decompiled view.
Previously, enum fields (e.g. System.DateTimeKind.Utc) would not include their associated XML documentation in metadata view.
This change ensures that the documentation is correctly surfaced.

The PR also adds a test to cover a simple enum from the System namespace.

Fixes # (issue, if applicable)

• #17939

Skaermoptagelse.2025-07-30.211243.mp4

Checklist

• Test cases added

• Performance benchmarks added in case of performance changes

• Release notes entry updated:

  Please make sure to add an entry with short succinct description of the change as well as link to this pull request to the respective release notes file, if applicable.

  Release notes files:

  • If anything under src/Compiler has been changed, please make sure to make an entry in docs/release-notes/.FSharp.Compiler.Service/<version>.md, where <version> is usually "highest" one, e.g. 42.8.200
  • If language feature was added (i.e. LanguageFeatures.fsi was changed), please add it to docs/release-notes/.Language/preview.md
  • If a change to FSharp.Core was made, please make sure to edit docs/release-notes/.FSharp.Core/<version>.md where version is "highest" one, e.g. 8.0.200.

  Information about the release notes entries format can be found in the documentation.
  Example:

  • More inlines for Result module. (PR #16106)
  • Correctly handle assembly imports with public key token of 0 length. (Issue #16359, PR #16363)
    *while! (Language suggestion #1038, PR #14238)

  If you believe that release notes are not necessary for this PR, please add NO_RELEASE_NOTES label to the pull request.

[github-actions]

❗ Release notes required

---

✅ Found changes and release notes in following paths:

Change path	Release notes path	Description
src/Compiler	docs/release-notes/.FSharp.Compiler.Service/10.0.100.md

[ThobiWanKenobi]

@dotnet-policy-service agree

[edgarfgp]

/run ilverify

[github-actions]

🔧 CLI Command Report

• Command: /run ilverify
• Outcome: success

✅ Command succeeded, no changes needed.

[ThobiWanKenobi]

So, I have been attempting to fix the ILVerify fail, but following the steps in the DEVGUIDE. However, I keep getting an error saying the following each time I run the ilverify.ps1 script from the /tests/ILVerify folder:

& : The module 'fsharp' could not be loaded. For more information, run 'Import-Module fsharp'.
At C:\Users\Stati\Projects\fsharp\tests\ILVerify\ilverify.ps1:44 char:11
+         & $script -c $configuration
+           ~~~~~~~
    + CategoryInfo          : ObjectNotFound: (fsharp\build.sh:String) [], CommandNotFoundException
    + FullyQualifiedErrorId : CouldNotAutoLoadModule

Does anyone know how I can resolve this issue, I cannot seem to figure out exactly what the problem seems to be

[T-Gro]

So, I have been attempting to fix the ILVerify fail, but following the steps in the DEVGUIDE. However, I keep getting an error saying the following each time I run the ilverify.ps1 script from the /tests/ILVerify folder:

& : The module 'fsharp' could not be loaded. For more information, run 'Import-Module fsharp'.
At C:\Users\Stati\Projects\fsharp\tests\ILVerify\ilverify.ps1:44 char:11
+         & $script -c $configuration
+           ~~~~~~~
    + CategoryInfo          : ObjectNotFound: (fsharp\build.sh:String) [], CommandNotFoundException
    + FullyQualifiedErrorId : CouldNotAutoLoadModule

Does anyone know how I can resolve this issue, I cannot seem to figure out exactly what the problem seems to be

What is your OS and working directory when invoking the script?
Maybe the script is written in a way the expects you cd into the directory first and then launch it? (this can be changed if this is the case)

[ThobiWanKenobi]

So, I have been attempting to fix the ILVerify fail, but following the steps in the DEVGUIDE. However, I keep getting an error saying the following each time I run the ilverify.ps1 script from the /tests/ILVerify folder:

& : The module 'fsharp' could not be loaded. For more information, run 'Import-Module fsharp'.
At C:\Users\Stati\Projects\fsharp\tests\ILVerify\ilverify.ps1:44 char:11
+         & $script -c $configuration
+           ~~~~~~~
    + CategoryInfo          : ObjectNotFound: (fsharp\build.sh:String) [], CommandNotFoundException
    + FullyQualifiedErrorId : CouldNotAutoLoadModule

Does anyone know how I can resolve this issue, I cannot seem to figure out exactly what the problem seems to be

What is your OS and working directory when invoking the script? Maybe the script is written in a way the expects you cd into the directory first and then launch it? (this can be changed if this is the case)

I am working on Windows 11 Pro 24H2. I tried running the script directly from the /tests/ILVerify folder. I also attempted to run it from the git root "fsharp", but it still returns the same kind of error.

[majocha]

Ah, you need to use new powershell, v 7.*

[ThobiWanKenobi]

Wait what... It turns out the default "Terminal" which I consider Powershell.... Is version 5.1.* 🤔🤔🤔I thought that it had the new version. I will give it a try with the updated version!

[vzarytovskii]

Yeah, I should've specified pwsh version, or just make it an fsx.

[majocha]

CI Failure unrelated.

[ThobiWanKenobi]

aw well, how nice, if its not the Macos one, then its just a Windows one... I don't understand, why does this pipeline seem so... unstable? Unpredictable? What is going on with this

[majocha]

Yeah, it's an ongoing effort to deflake it. The test suite has some layers of legacy stuff.

[ThobiWanKenobi]

Ah yeah that makes sense. So we are actively trying to improve it, that is nice to hear! :D

[ThobiWanKenobi]

Thanks for the review! I will address the comments and see if I can improve the code later today :D

[ThobiWanKenobi]

I addressed the comments from the PR, and attempted in general to improve the code quality of my PR. Does this need release notes, or should I just add the label to push it without?

[T-Gro]

Please add a one-liner to docs/release-notes/.FSharp.Compiler.Service/10.0.100.md , that will do it 👍

[Martin521]

@ThobiWanKenobi: Thank you and congrats to your first F# compiler PR!

[ThobiWanKenobi]

Thank you! :D This is also my first open source contribution in general! I learned so much from this experience! I will probably be back in not too soon!

[T-Gro]

Lovely to read that. Eagerly waiting to seeing you soon 👍 :))

[edgarfgp]

Thank you! :D This is also my first open source contribution in general! I learned so much from this experience! I will probably be back in not too soon!

@ThobiWanKenobi Awesome job.