Move LSP development to the main branch #18653
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Adam Boniecki <[email protected]>
Merge main to lsp
Merge main to lsp
Merge main to lsp
Merge main to lsp
Merge main to lsp
Merge main to lsp
Merge main to lsp
Merge main to lsp
Merge main to lsp
Merge main to lsp
Merge main to lsp
Get comp args lsp
Merge main to lsp
Merge main to lsp
[automated] Merge branch 'main' => 'feature/lsp'
Add a null check to FSharpWorkspace
…kspace.fs Co-authored-by: Tomas Grosup <[email protected]>
Fix merge from main to feature/lsp
|
abonie
added
the
NO_RELEASE_NOTES
T-Gro
reviewed
Jun 4, 2025
T-Gro
reviewed
Jun 4, 2025
src/FSharp.Compiler.LanguageServer/FSharp.Compiler.LanguageServer.fsproj
Show resolved
Hide resolved
T-Gro
approved these changes
Jun 4, 2025
github-project-automation
bot
moved this from New
to In Progress
in F# Compiler and Tooling
Go back to trying to use GetLastModifiedTimeOnDisk to decide if file should be read from disk. As the TODO comment explains, it is flawed in that in doesn't always switch to in-memory mode when possible, but that's still better than ignoring changes made outside the editor
abonie
commented
Jun 5, 2025
abonie
commented
Jun 5, 2025
github-project-automation
bot
moved this from In Progress
to Done
in F# Compiler and Tooling
This was referenced Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Merges from main to feature/lsp take too much time to resolve due to updating baselines