Fix warn scopes trivia for fantomas #18637
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❗ Release notes required
|
Martin521
changed the title
T-Gro
approved these changes
May 30, 2025
github-project-automation
bot
moved this from New
to In Progress
in F# Compiler and Tooling
|
Strange, ILVerify succeeds locally, fails in CI. |
Also in Release? |
auto-merge was automatically disabled
June 2, 2025 16:33
Head branch was pushed to by a user without write access
|
I am sure I double-checked last week. Anyway, it seems to be ok now. |
This was referenced Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #18636
When adding "scoped nowarn" #18049, I misinterpreted how trivia are meant to be used. While working on the necessary Fantomas adaptation, I found now I should follow the way trivia for conditional directives (#if) are handled. This means that the whole line (including indentation and possibly comment) has to be reported as trivia. Currently, the comment is reported separately. Having two trivia in a row, however, cannot easily be handled in Fantomas. And consistency with conditional directives makes sense anyway.
This also simplifies some of the "scoped nowarn" code.
Checklist