Remove deoptimizations in FSharp.Test.Utilities #18606
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ No release notes required |
T-Gro
approved these changes
May 26, 2025
github-project-automation
bot
moved this from New
to In Progress
in F# Compiler and Tooling
|
If this does not touch baselines, it is good to go for me. One reason I could in theory imagine is stability across DEBUG vs RELEASE baselines, to make dev life easier (since typically one would run tests in debug from IDE, whereas CI is running everything in release). |
github-project-automation
bot
moved this from In Progress
to Done
in F# Compiler and Tooling
This was referenced Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just to see if things still work. I can't think of a reason this particular project needs to disable optimizations and tailcalls.