Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
1799aaf
make attribute targets mismatches a warning and not an error.
edgarfgp Apr 23, 2025
55507e9
release notes
edgarfgp Apr 23, 2025
1738018
update tests
edgarfgp Apr 23, 2025
65f5bb6
Merge branch 'main' into fix-attr-targets
edgarfgp Apr 24, 2025
0c97b9d
Merge branch 'main' into fix-attr-targets
edgarfgp Apr 27, 2025
6f2b706
update baselines
edgarfgp Apr 29, 2025
e8f1bb0
Merge branch 'main' into fix-attr-targets
edgarfgp Apr 29, 2025
75d8f5e
Update baselines
edgarfgp Apr 29, 2025
4f2e97e
Merge branch 'fix-attr-targets' of github.com:edgarfgp/fsharp into fi…
edgarfgp Apr 29, 2025
63be5d5
Merge branch 'main' into fix-attr-targets
edgarfgp Apr 30, 2025
4248f2a
Move attribute form logic to an AP
edgarfgp Apr 30, 2025
cc96217
Merge branch 'main' into fix-attr-targets
edgarfgp May 1, 2025
e270b88
Merge branch 'main' into fix-attr-targets
edgarfgp May 1, 2025
e0cc65a
Merge branch 'main' into fix-attr-targets
edgarfgp May 2, 2025
1e29d58
Merge branch 'main' into fix-attr-targets
edgarfgp May 5, 2025
1470bf9
Merge branch 'main' into fix-attr-targets
edgarfgp May 6, 2025
8988215
Merge branch 'main' into fix-attr-targets
edgarfgp May 7, 2025
74712e8
Merge branch 'main' into fix-attr-targets
edgarfgp May 12, 2025
967c4a9
Merge branch 'main' of github.com:edgarfgp/fsharp
edgarfgp May 13, 2025
a30cef4
Merge branch 'dotnet:main' into main
edgarfgp May 22, 2025
1e342d8
Add RQUOTE_BAR_RBRACE
edgarfgp May 23, 2025
90d0fa0
add syntax tree tests
edgarfgp May 23, 2025
a87782f
update ilveryfy
edgarfgp May 23, 2025
808da9d
more tests
edgarfgp May 23, 2025
e0894da
Merge branch 'main' into fix-18597
edgarfgp May 23, 2025
69e85e6
update baselines
edgarfgp May 23, 2025
2d9309f
update baselines
edgarfgp May 23, 2025
4f28afe
Merge branch 'fix-18597' of github.com:edgarfgp/fsharp into fix-18597
edgarfgp May 23, 2025
024097c
release notes
edgarfgp May 24, 2025
db32b8e
Merge branch 'main' into fix-18597
edgarfgp May 26, 2025
db3ca66
Merge branch 'main' into fix-18597
edgarfgp May 26, 2025
927d93f
Merge branch 'main' into fix-18597
edgarfgp May 26, 2025
37efb81
Merge branch 'main' into fix-18597
edgarfgp May 28, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/release-notes/.FSharp.Compiler.Service/10.0.100.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
### Fixed

* Fix parsing errors using anonymous records and units of measures ([PR #18543](https://github.com/dotnet/fsharp/pull/18543))
* Fix parsing errors using anonymous records and code quotations ([PR #18603](https://github.com/dotnet/fsharp/pull/18603))
* Fixed: Allow `return`, `return!`, `yield`, `yield!` type annotations without parentheses ([PR #18533](https://github.com/dotnet/fsharp/pull/18533))
* Allow `let!` and `use!` type annotations without requiring parentheses ([PR #18508](https://github.com/dotnet/fsharp/pull/18508))
* Fix find all references for F# exceptions ([PR #18565](https://github.com/dotnet/fsharp/pull/18565))
Expand Down
1 change: 1 addition & 0 deletions src/Compiler/Driver/CompilerDiagnostics.fs
Original file line number Diff line number Diff line change
Expand Up @@ -1168,6 +1168,7 @@ type Exception with
| Parser.TOKEN_GREATER_RBRACK -> SR.GetString("Parser.TOKEN.GREATER.RBRACK")
| Parser.TOKEN_RQUOTE_DOT
| Parser.TOKEN_RQUOTE -> SR.GetString("Parser.TOKEN.RQUOTE")
| Parser.TOKEN_RQUOTE_BAR_RBRACE -> SR.GetString("Parser.TOKEN.RQUOTE.BAR.RBRACE")
| Parser.TOKEN_RBRACK -> SR.GetString("Parser.TOKEN.RBRACK")
| Parser.TOKEN_RBRACE
| Parser.TOKEN_RBRACE_COMING_SOON
Expand Down
3 changes: 3 additions & 0 deletions src/Compiler/FSStrings.resx
Original file line number Diff line number Diff line change
Expand Up @@ -360,6 +360,9 @@
<data name="Parser.TOKEN.GREATER.BAR.RBRACE" xml:space="preserve">
<value>symbol '&gt;|}'</value>
</data>
<data name="Parser.TOKEN.RQUOTE.BAR.RBRACE" xml:space="preserve">
<value>symbol '@&gt;|}' or '@@&gt;|}'</value>
</data>
<data name="Parser.TOKEN.GREATER.BAR.RBRACK" xml:space="preserve">
<value>symbol '&gt;|]'</value>
</data>
Expand Down
3 changes: 3 additions & 0 deletions src/Compiler/Service/ServiceLexing.fs
Original file line number Diff line number Diff line change
Expand Up @@ -287,6 +287,7 @@ module internal TokenClassifications =
| GREATER_BAR_RBRACK -> (FSharpTokenColorKind.Punctuation, FSharpTokenCharKind.Delimiter, FSharpTokenTriggerClass.None)

| RQUOTE _
| RQUOTE_BAR_RBRACE _
| RBRACK
| RBRACE _
| RBRACE_COMING_SOON
Expand Down Expand Up @@ -1389,6 +1390,7 @@ type FSharpTokenKind =
| RightArrow
| GreaterBarRightBracket
| GreaterBarRightBrace
| RQuoteBarRightBrace
| LeftParenthesisStarRightParenthesis
| Open
| Or
Expand Down Expand Up @@ -1659,6 +1661,7 @@ type FSharpToken =
| LQUOTE _ -> FSharpTokenKind.LeftQuote
| RQUOTE _ -> FSharpTokenKind.RightQuote
| RQUOTE_DOT _ -> FSharpTokenKind.RightQuoteDot
| RQUOTE_BAR_RBRACE _ -> FSharpTokenKind.RQuoteBarRightBrace
| PERCENT_OP _ -> FSharpTokenKind.PercentOperator
| BINDER _ -> FSharpTokenKind.Binder
| LESS _ -> FSharpTokenKind.Less
Expand Down
1 change: 1 addition & 0 deletions src/Compiler/Service/ServiceLexing.fsi
Original file line number Diff line number Diff line change
Expand Up @@ -458,6 +458,7 @@ type public FSharpTokenKind =
| RightArrow
| GreaterBarRightBracket
| GreaterBarRightBrace
| RQuoteBarRightBrace
| LeftParenthesisStarRightParenthesis
| Open
| Or
Expand Down
12 changes: 12 additions & 0 deletions src/Compiler/SyntaxTree/LexFilter.fs
Original file line number Diff line number Diff line change
Expand Up @@ -1210,6 +1210,11 @@ type LexFilterImpl (
delayToken (pool.UseShiftedLocation(tokenTup, BAR_RBRACK, 1, 0))
delayToken (pool.UseShiftedLocation(tokenTup, GREATER res, 0, -2))
pool.Return tokenTup
| RQUOTE_BAR_RBRACE x ->
lexbuf.CheckLanguageFeatureAndRecover LanguageFeature.BetterAnonymousRecordParsing lexbuf.LexemeRange
delayToken (pool.UseShiftedLocation(tokenTup, BAR_RBRACE, 1, 0))
delayToken (pool.UseShiftedLocation(tokenTup, RQUOTE(x), 0, -2))
pool.Return tokenTup
| GREATER_RBRACK ->
delayToken (pool.UseShiftedLocation(tokenTup, RBRACK, 1, 0))
delayToken (pool.UseShiftedLocation(tokenTup, GREATER res, 0, -1))
Expand Down Expand Up @@ -2631,6 +2636,13 @@ type LexFilterImpl (
noMerge()
true

| RQUOTE_BAR_RBRACE x ->
lexbuf.CheckLanguageFeatureAndRecover LanguageFeature.BetterAnonymousRecordParsing lexbuf.LexemeRange
delayToken (pool.UseShiftedLocation(tokenTup, BAR_RBRACE, 1, 0))
delayToken (pool.UseShiftedLocation(tokenTup, RQUOTE(x), 0, -2))
pool.Return tokenTup
true

| _ ->
false

Expand Down
4 changes: 4 additions & 0 deletions src/Compiler/lex.fsl
Original file line number Diff line number Diff line change
Expand Up @@ -839,6 +839,10 @@ rule token (args: LexArgs) (skip: bool) = parse

| "@@>" { checkExprOp lexbuf; RQUOTE ("<@@ @@>", true) }

| "@>|}" { RQUOTE_BAR_RBRACE ("<@ @>", false) }

| "@@>|}" { RQUOTE_BAR_RBRACE ("<@@ @@>", true) }

| '#' { HASH }

| '&' { AMP }
Expand Down
2 changes: 1 addition & 1 deletion src/Compiler/pars.fsy
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ let parse_error_rich = Some(fun (ctxt: ParseErrorContext<_>) ->
%token <bool> LET YIELD YIELD_BANG AND_BANG
%token <bool> LESS GREATER /* here the bool indicates if the tokens are part of a type application or type parameter declaration, e.g. C<int>, detected by the lex filter */
%token <string> PERCENT_OP BINDER
%token <string * bool> LQUOTE RQUOTE RQUOTE_DOT
%token <string * bool> LQUOTE RQUOTE RQUOTE_DOT RQUOTE_BAR_RBRACE
%token BAR_BAR UPCAST DOWNCAST NULL RESERVED MODULE NAMESPACE DELEGATE CONSTRAINT BASE
%token AND AS ASSERT OASSERT ASR BEGIN DO DONE DOWNTO ELSE ELIF END DOT_DOT DOT_DOT_HAT
%token EXCEPTION FALSE FOR FUN FUNCTION IF IN JOIN_IN FINALLY DO_BANG
Expand Down
5 changes: 5 additions & 0 deletions src/Compiler/xlf/FSStrings.cs.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions src/Compiler/xlf/FSStrings.de.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions src/Compiler/xlf/FSStrings.es.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions src/Compiler/xlf/FSStrings.fr.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions src/Compiler/xlf/FSStrings.it.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions src/Compiler/xlf/FSStrings.ja.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions src/Compiler/xlf/FSStrings.ko.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions src/Compiler/xlf/FSStrings.pl.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions src/Compiler/xlf/FSStrings.pt-BR.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions src/Compiler/xlf/FSStrings.ru.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions src/Compiler/xlf/FSStrings.tr.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions src/Compiler/xlf/FSStrings.zh-Hans.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions src/Compiler/xlf/FSStrings.zh-Hant.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading