Skip to content

Allow return|return! yield|yield! and type annotations without parentheses #18533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 27 commits into from
May 22, 2025
Merged

Allow return|return! yield|yield! and type annotations without parentheses #18533

merged 27 commits into from
May 22, 2025

Conversation

@edgarfgp
Copy link
Contributor

@edgarfgp edgarfgp commented May 5, 2025 •
edited
Loading

Description

Fixes #15788

Checklist

  • Test cases added
  • Release notes entry updated

@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2025 •
edited
Loading

❗ Release notes required

✅ Found changes and release notes in following paths:

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/10.0.100.md

@edgarfgp edgarfgp changed the title allow return|return! yield|yield! and type annotations without parentheses Allow return|return! yield|yield! and type annotations without parentheses May 5, 2025
auduchinok
auduchinok reviewed May 6, 2025
View reviewed changes
@edgarfgp edgarfgp marked this pull request as ready for review May 6, 2025 19:14
@edgarfgp edgarfgp requested a review from a team as a code owner May 6, 2025 19:14
@edgarfgp edgarfgp closed this May 15, 2025
@edgarfgp edgarfgp reopened this May 15, 2025
T-Gro
T-Gro reviewed May 16, 2025
View reviewed changes
T-Gro
T-Gro reviewed May 19, 2025
View reviewed changes
T-Gro
T-Gro reviewed May 19, 2025
View reviewed changes
T-Gro
T-Gro reviewed May 19, 2025
View reviewed changes
@edgarfgp edgarfgp closed this May 20, 2025
@edgarfgp edgarfgp reopened this May 20, 2025
@edgarfgp
Copy link
Contributor Author

@T-Gro Im getting dotnet-ilverify is not installed. Installing... Unhandled exception: System.Net.Http.HttpRequestException: Response status code does not indicate success: 503 (Service Unavailable). can you please do the /azn run ?

@T-Gro
Copy link
Member

T-Gro commented May 21, 2025

/run ilverify

@github-actions
Copy link
Contributor

Started to run ilverify baseline update

@github-actions
Copy link
Contributor

Ran ilverify: https://github.com/dotnet/fsharp/actions/runs/15159958952
The ilverify command ran and did not modify any baseline.

@T-Gro
Copy link
Member

T-Gro commented May 21, 2025

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@T-Gro T-Gro merged commit d67ac13 into dotnet:main May 22, 2025
33 checks passed
This was referenced Jun 16, 2025
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@T-Gro T-Gro T-Gro approved these changes

+1 more reviewer

@auduchinok auduchinok auduchinok left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

F# Compiler and Tooling
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allow CE return and type annotations to play well together without needing parentheses

3 participants

@edgarfgp @T-Gro @auduchinok