Cancellable: always catch internal cancellations #18531
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
I think this worked before and I broke it the previous time I touched this code. |
|
This just reverts a bug recently introduced in #18309. Maybe no release notes needed. |
edgarfgp
added
the
NO_RELEASE_NOTES
T-Gro
approved these changes
May 12, 2025
abonie
approved these changes
May 14, 2025
This was referenced Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been running Visual Studio in debug mode and I noticed a lot of assertions related to cancellation.
Cancellable.CheckAndThrow()surfaces as an internal error, despite being in the context ofcancellableworkflow, for example here:fsharp/src/Compiler/Service/FSharpCheckerResults.fs
Lines 3284 to 3285 in 172dc31
This seems benign in real use, but I think is not correct. It's also annoying when trying to test things in debug mode.
The fix is to handle such things in the cancellable builder.
Update: This worked before, and I broke it. This PR just reverts relevant parts of the code.
cc: @auduchinok