Fix race in cache eviction #18528
Merged
Fix race in cache eviction #18528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
majocha
commented
May 2, 2025
majocha
commented
May 2, 2025
majocha
commented
May 7, 2025
majocha
commented
May 7, 2025
|
I think additional release notes are not needed here. This is just a bugfix for #18527 |
edgarfgp
added
the
NO_RELEASE_NOTES
T-Gro
reviewed
May 12, 2025
T-Gro
approved these changes
May 14, 2025
abonie
approved these changes
May 14, 2025
github-project-automation
bot
moved this from New
to In Progress
in F# Compiler and Tooling
github-project-automation
bot
moved this from In Progress
to Done
in F# Compiler and Tooling
This was referenced Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I spotted a bug in the recently merged general purpose cache.
Let's fix it before folks start complaining.
The following assertion not always holds:
fsharp/src/Compiler/Utilities/Caches.fs
Line 249 in 63dd8ca
This assert failure can be seen under heavier us in debug mode in VS.
The reason is that we post eviction queue messages on store updates, which are not in sync with the eviciton queue mailboxprocessor (and we don't want them to be, it would hurt the performance). In effect it is possible that
Updatefor an item is posted beforeAdd.The simple fix is to turn the assertion into condition.
The rest of this PR are some refactorings to make the code clearer.