Skip to content

include accessibility range in SynPat.Named #18526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
May 2, 2025
Merged

include accessibility range in SynPat.Named #18526

merged 8 commits into from
May 2, 2025
+267 −1

Conversation

@edgarfgp
Copy link
Contributor

@edgarfgp edgarfgp commented Apr 29, 2025 •
edited
Loading

Description

Fixes #13115

Checklist

  • Test cases added
  • Release notes entry updated

@github-actions
Copy link
Contributor

github-actions bot commented Apr 29, 2025 •
edited
Loading

❗ Release notes required

✅ Found changes and release notes in following paths:

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/9.0.300.md

auduchinok
auduchinok approved these changes Apr 29, 2025
View reviewed changes
Copy link
Member

@auduchinok auduchinok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Could you please also add test cases for nested patterns like tuples where access modifiers are allowed?

@edgarfgp edgarfgp marked this pull request as ready for review April 30, 2025 12:54
@edgarfgp edgarfgp requested a review from a team as a code owner April 30, 2025 12:54
@edgarfgp
Copy link
Contributor Author

This is ready

@T-Gro T-Gro enabled auto-merge (squash) April 30, 2025 20:09
@T-Gro T-Gro merged commit 172dc31 into dotnet:main May 2, 2025
33 checks passed
This was referenced Jun 16, 2025
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abonie abonie abonie approved these changes

@T-Gro T-Gro T-Gro approved these changes

+2 more reviewers

@auduchinok auduchinok auduchinok approved these changes

@brianrourkeboll brianrourkeboll brianrourkeboll approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

F# Compiler and Tooling
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Range of SynPat.Named doesn't include accessibility

5 participants

@edgarfgp @auduchinok @brianrourkeboll @abonie @T-Gro