Skip to content

Conversation

@auduchinok
Copy link
Member

Fixes various cases of broken code completion inside do statements inside type declarations:

type T() =
    do
        "".ToString().L{caret}

Example 1:
Screenshot 2025-04-28 at 22 55 45

Example 2:
Screenshot 2025-04-28 at 22 16 32

This PR also simplifies the code completion testing helpers and updates tests added in #18519, so that PR should be merged first.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 29, 2025

❗ Release notes required


✅ Found changes and release notes in following paths:

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/9.0.300.md

@auduchinok auduchinok force-pushed the completion-typeDecl-do-expr branch 2 times, most recently from 352595c to 98c38fc Compare April 29, 2025 18:47
@github-project-automation github-project-automation bot moved this from New to In Progress in F# Compiler and Tooling Apr 30, 2025
@auduchinok auduchinok force-pushed the completion-typeDecl-do-expr branch from 98c38fc to c43a6e6 Compare April 30, 2025 12:58
@T-Gro T-Gro merged commit 34dbfc1 into dotnet:main Apr 30, 2025
33 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in F# Compiler and Tooling Apr 30, 2025
@auduchinok auduchinok deleted the completion-typeDecl-do-expr branch May 6, 2025 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants