Skip to content

Conversation

@brianrourkeboll
Copy link
Contributor

Description

  • Redefine "pair" ordering in terms of struct tuples instead of reference tuples.

range and pos comparisons don't seem to be very widespread in the compiler/tooling, so this may not have much effect on compiler/tooling performance, but heap-allocating reference tuples for every comparison of range and pos seems unnecessary.

Checklist

  • Release notes entry updated: I don't think they're necessary.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 27, 2025

⚠️ Release notes required, but author opted out

Warning

Author opted out of release notes, check is disabled for this pull request.
cc @dotnet/fsharp-team-msft

@T-Gro T-Gro added the NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes label Apr 29, 2025
@T-Gro T-Gro marked this pull request as ready for review May 22, 2025 07:57
@T-Gro T-Gro requested a review from a team as a code owner May 22, 2025 07:57
@T-Gro T-Gro enabled auto-merge (squash) May 22, 2025 07:57
@T-Gro T-Gro merged commit fb50b56 into dotnet:main May 22, 2025
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants